From 784704d0e01dfd46a651deecc98a06afa9c67abb Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Fri, 26 Nov 2021 19:37:59 -0800 Subject: [PATCH] GDI+ plugin: [nfc] avoid directly modifying 'FileStream' refcount MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This change redirects all reference count modifications through `AddRef` instead direction increments. Based on Microsoft sample implementation.¹ ¹ https://docs.microsoft.com/en-us/previous-versions/windows/desktop/ms752876(v=vs.85) --- plugin/gdiplus/FileStream.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/plugin/gdiplus/FileStream.cpp b/plugin/gdiplus/FileStream.cpp index 7361fd83d..0fe700814 100644 --- a/plugin/gdiplus/FileStream.cpp +++ b/plugin/gdiplus/FileStream.cpp @@ -29,19 +29,19 @@ HRESULT FileStream::QueryInterface( if (riid == IID_IUnknown) { *ppvObject = this; - ++_ref; + AddRef(); return S_OK; } else if (riid == IID_ISequentialStream) { *ppvObject = this; - ++_ref; + AddRef(); return S_OK; } else if (riid == IID_IStream) { *ppvObject = this; - ++_ref; + AddRef(); return S_OK; } else -- 2.40.0