From 77bbf2270ce7c166c87933dc2d70e9619bf6b6e3 Mon Sep 17 00:00:00 2001 From: Nicolas PLANEL Date: Tue, 26 Aug 2014 11:31:15 -0400 Subject: [PATCH] xfrm: fix an unintialized return value on memory allocation error in xfrmnl_ae_parse() fix : err = -ENOMEM if calloc() failed Signed-off-by: Thomas Haller --- lib/xfrm/ae.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/xfrm/ae.c b/lib/xfrm/ae.c index a4db300..4fe9647 100644 --- a/lib/xfrm/ae.c +++ b/lib/xfrm/ae.c @@ -533,8 +533,10 @@ int xfrmnl_ae_parse(struct nlmsghdr *n, struct xfrmnl_ae **result) struct xfrm_replay_state_esn* esn = nla_data (tb[XFRMA_REPLAY_ESN_VAL]); uint32_t len = sizeof (struct xfrmnl_replay_state_esn) + (sizeof (uint32_t) * esn->bmp_len); - if ((ae->replay_state_esn = calloc (1, len)) == NULL) + if ((ae->replay_state_esn = calloc (1, len)) == NULL) { + err = -ENOMEM; goto errout; + } ae->replay_state_esn->oseq = esn->oseq; ae->replay_state_esn->seq = esn->seq; ae->replay_state_esn->oseq_hi = esn->oseq_hi; -- 2.40.0