From 77b5e464586becd92dff2b6b256e74213301e653 Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Sat, 16 Dec 2017 02:10:16 +0000 Subject: [PATCH] [WebAssembly] Return ArrayRef's rather than const std::vector& From working on lld I've learned this is generally the preferred way for several reasons (e.g. more concise, improves encapsulation). Differential Revision: https://reviews.llvm.org/D41265 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@320906 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Object/Wasm.h | 32 +++++++++++--------------------- 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/include/llvm/Object/Wasm.h b/include/llvm/Object/Wasm.h index 589c0b5ea11..a129aeef4f4 100644 --- a/include/llvm/Object/Wasm.h +++ b/include/llvm/Object/Wasm.h @@ -128,28 +128,18 @@ public: static bool classof(const Binary *v) { return v->isWasm(); } - const std::vector& types() const { return Signatures; } - const std::vector& functionTypes() const { return FunctionTypes; } - const std::vector& imports() const { return Imports; } - const std::vector& tables() const { return Tables; } - const std::vector& memories() const { return Memories; } - const std::vector& globals() const { return Globals; } - const std::vector& exports() const { return Exports; } + ArrayRef types() const { return Signatures; } + ArrayRef functionTypes() const { return FunctionTypes; } + ArrayRef imports() const { return Imports; } + ArrayRef tables() const { return Tables; } + ArrayRef memories() const { return Memories; } + ArrayRef globals() const { return Globals; } + ArrayRef exports() const { return Exports; } const wasm::WasmLinkingData& linkingData() const { return LinkingData; } - - uint32_t getNumberOfSymbols() const { - return Symbols.size(); - } - - const std::vector& elements() const { - return ElemSegments; - } - - const std::vector& dataSegments() const { - return DataSegments; - } - - const std::vector& functions() const { return Functions; } + uint32_t getNumberOfSymbols() const { return Symbols.size(); } + ArrayRef elements() const { return ElemSegments; } + ArrayRef dataSegments() const { return DataSegments; } + ArrayRef functions() const { return Functions; } const ArrayRef& code() const { return CodeSection; } uint32_t startFunction() const { return StartFunction; } -- 2.49.0