From 7780c36046d448da7dd4cbfce16f260ca0815944 Mon Sep 17 00:00:00 2001 From: Fariborz Jahanian Date: Tue, 14 Apr 2015 17:21:58 +0000 Subject: [PATCH] [SemaCXX patch] Patch to fix a crash when a 'delete' constructor is being accessed. Reviewed by Richard Smith. rdar://20281011 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@234912 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaOverload.cpp | 9 +++-- .../cxx11-call-to-deleted-constructor.cpp | 40 +++++++++++++++++++ 2 files changed, 45 insertions(+), 4 deletions(-) create mode 100644 test/SemaCXX/cxx11-call-to-deleted-constructor.cpp diff --git a/lib/Sema/SemaOverload.cpp b/lib/Sema/SemaOverload.cpp index cf84f23baf..8f9401b38a 100644 --- a/lib/Sema/SemaOverload.cpp +++ b/lib/Sema/SemaOverload.cpp @@ -2954,7 +2954,10 @@ IsInitializerListConstructorConversion(Sema &S, Expr *From, QualType ToType, bool HadMultipleCandidates = (CandidateSet.size() > 1); OverloadCandidateSet::iterator Best; - switch (CandidateSet.BestViableFunction(S, From->getLocStart(), Best, true)) { + switch (auto Result = + CandidateSet.BestViableFunction(S, From->getLocStart(), + Best, true)) { + case OR_Deleted: case OR_Success: { // Record the standard conversion we used and the conversion function. CXXConstructorDecl *Constructor = cast(Best->Function); @@ -2967,13 +2970,11 @@ IsInitializerListConstructorConversion(Sema &S, Expr *From, QualType ToType, User.After.setAsIdentityConversion(); User.After.setFromType(ThisType->getAs()->getPointeeType()); User.After.setAllToTypes(ToType); - return OR_Success; + return Result; } case OR_No_Viable_Function: return OR_No_Viable_Function; - case OR_Deleted: - return OR_Deleted; case OR_Ambiguous: return OR_Ambiguous; } diff --git a/test/SemaCXX/cxx11-call-to-deleted-constructor.cpp b/test/SemaCXX/cxx11-call-to-deleted-constructor.cpp new file mode 100644 index 0000000000..dd04345281 --- /dev/null +++ b/test/SemaCXX/cxx11-call-to-deleted-constructor.cpp @@ -0,0 +1,40 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s +// rdar://20281011 + +namespace std { +template class initializer_list { }; +} + +namespace cva { + +template +class Matrix { +public: + + typedef VT value_type; + inline __attribute__((always_inline)) value_type& at(); +}; + +template using Vector = Matrix; + +template +using RGBValue = Vector; +using RGBFValue = RGBValue; + +template class Matrix { // expected-note {{passing argument to parameter here}} +public: + typedef VT value_type; + Matrix(const unsigned int nRows, const unsigned int nColumns, const value_type* data = nullptr); + + Matrix(const std::initializer_list& list) = delete; // expected-note {{'Matrix' has been explicitly marked deleted here}} + +}; + +void getLaplacianClosedForm() +{ + Matrix winI(0, 3); + RGBFValue* inputPreL; + winI = { inputPreL->at() }; // expected-error {{call to deleted constructor of 'cva::Matrix &&'}} +} + +} -- 2.50.1