From 75525c4cce5e1e097d3fab4391b11619d87cedfd Mon Sep 17 00:00:00 2001 From: Fariborz Jahanian Date: Wed, 6 Mar 2013 00:37:40 +0000 Subject: [PATCH] objective-C: don't crash after diagnosing using object subscripting without declaring objectForKeyedSubscript: // rdar://13333205 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@176539 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaExpr.cpp | 4 ++-- ...{boxing-illegal-types.m => boxing-illegal.m} | 17 +++++++++++++++++ 2 files changed, 19 insertions(+), 2 deletions(-) rename test/SemaObjC/{boxing-illegal-types.m => boxing-illegal.m} (78%) diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp index e1b9950eca..840a71461e 100644 --- a/lib/Sema/SemaExpr.cpp +++ b/lib/Sema/SemaExpr.cpp @@ -547,7 +547,7 @@ ExprResult Sema::UsualUnaryConversions(Expr *E) { // First, convert to an r-value. ExprResult Res = DefaultFunctionArrayLvalueConversion(E); if (Res.isInvalid()) - return Owned(E); + return ExprError(); E = Res.take(); QualType Ty = E->getType(); @@ -598,7 +598,7 @@ ExprResult Sema::DefaultArgumentPromotion(Expr *E) { ExprResult Res = UsualUnaryConversions(E); if (Res.isInvalid()) - return Owned(E); + return ExprError(); E = Res.take(); // If this is a 'float' or '__fp16' (CVR qualified or typedef) promote to diff --git a/test/SemaObjC/boxing-illegal-types.m b/test/SemaObjC/boxing-illegal.m similarity index 78% rename from test/SemaObjC/boxing-illegal-types.m rename to test/SemaObjC/boxing-illegal.m index ad45b11f2d..59b5c8b710 100644 --- a/test/SemaObjC/boxing-illegal-types.m +++ b/test/SemaObjC/boxing-illegal.m @@ -56,3 +56,20 @@ void testEnum(void *p) { box = @(ME_foo); box = @(*(enum ForwE*)p); // expected-error {{incomplete type 'enum ForwE' used in a boxed expression}} } + +// rdar://13333205 +@class NSMutableDictionary; + +@interface NSMutableArray ++ (NSMutableArray*) array; +@end + +NSMutableDictionary* mBars; + +__attribute((objc_root_class)) @interface rdar13333205 @end + +@implementation rdar13333205 +- (void) insertBar:(id)preset ofKind:(id) kind atIndex:(int)index { + NSMutableArray* presetArray = mBars[kind] ?: [NSMutableArray array]; // expected-error {{expected method to read dictionary element not found on object of type 'NSMutableDictionary *'}} +} +@end -- 2.40.0