From 730dfe8fc7b836de3d987f1984f74c0fc35ba22c Mon Sep 17 00:00:00 2001 From: Badlop Date: Wed, 11 Apr 2012 16:34:03 +0200 Subject: [PATCH] Add comments about Dialyzer warnings --- src/ejabberd_update.erl | 3 +++ src/eldap/eldap.erl | 1 + 2 files changed, 4 insertions(+) diff --git a/src/ejabberd_update.erl b/src/ejabberd_update.erl index a878e9be4..7572d3da4 100644 --- a/src/ejabberd_update.erl +++ b/src/ejabberd_update.erl @@ -69,6 +69,7 @@ update(ModulesToUpdate) -> %% OTP R14B03 and older provided release_handler_1:eval_script/3 %% But OTP R14B04 and newer provide release_handler_1:eval_script/5 +%% Dialyzer reports a call to missing function; don't worry. eval_script(Script, Apps, LibDirs) -> case lists:member({eval_script, 5}, release_handler_1:module_info(exports)) of true -> @@ -143,6 +144,8 @@ build_script(Dir, UpdatedBeams) -> [{ejabberd, "", filename:join(Dir, "..")}]), case Check of ok -> + %% This clause is for OTP R14B03 and older. + %% Newer Dialyzer reports a never match pattern; don't worry. ?DEBUG("script: ~p~n", [Script]), ?DEBUG("low level script: ~p~n", [LowLevelScript]), ?DEBUG("check: ~p~n", [Check]); diff --git a/src/eldap/eldap.erl b/src/eldap/eldap.erl index 354ab297e..265845e90 100644 --- a/src/eldap/eldap.erl +++ b/src/eldap/eldap.erl @@ -439,6 +439,7 @@ init([]) -> end; init({Hosts, Port, Rootdn, Passwd, Opts}) -> catch ssl:start(), + %% ssl:seed was removed in OTP R14B04, newer Dialyzer will complain catch ssl:seed(randoms:get_string()), Encrypt = case proplists:get_value(encrypt, Opts) of tls -> tls; -- 2.50.0