From 72fe2b16f68f3c17cf25d07ed3b8adb228d8893f Mon Sep 17 00:00:00 2001
From: Hugh McMaster <hugh.mcmaster@outlook.com>
Date: Sun, 2 Jun 2019 10:13:39 +1000
Subject: [PATCH] ext/skeleton: Update use of PHP_CHECK_LIBRARY

Closes GH-4218.
---
 ext/skeleton/config.m4.in | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/ext/skeleton/config.m4.in b/ext/skeleton/config.m4.in
index 268a48ba2f..cc7c6354bb 100644
--- a/ext/skeleton/config.m4.in
+++ b/ext/skeleton/config.m4.in
@@ -62,25 +62,25 @@ if test "$PHP_%EXTNAMECAPS%" != "no"; then
   dnl LIBNAME=%EXTNAMECAPS% # you may want to change this
   dnl LIBSYMBOL=%EXTNAMECAPS% # you most likely want to change this
 
-  dnl If you need to check for a particular library function
-  dnl and you are using pkg-config:
+  dnl If you need to check for a particular library function (e.g. a conditional
+  dnl or version-dependent feature) and you are using pkg-config:
   dnl PHP_CHECK_LIBRARY($LIBNAME, $LIBSYMBOL,
   dnl [
-  dnl   PHP_EVAL_INCLINE($LIBFOO_CFLAGS)
-  dnl   PHP_EVAL_LIBLINE($LIBFOO_LIBS, %EXTNAMECAPS%_SHARED_LIBADD)
-  dnl   AC_DEFINE(HAVE_%EXTNAMECAPS%LIB, 1, [ ])
+  dnl   AC_DEFINE(HAVE_%EXTNAMECAPS%_FEATURE, 1, [ ])
   dnl ],[
-  dnl   AC_MSG_ERROR([wrong %EXTNAME% lib version or lib not found])
+  dnl   AC_MSG_ERROR([FEATURE not supported by your %EXTNAME% library.])
+  dnl ], [
+  dnl   $LIBFOO_LIBS
   dnl ])
 
-  dnl If you need to check for a particular library function
-  dnl and you are not using pkg-config:
+  dnl If you need to check for a particular library function (e.g. a conditional
+  dnl or version-dependent feature) and you are not using pkg-config:
   dnl PHP_CHECK_LIBRARY($LIBNAME, $LIBSYMBOL,
   dnl [
   dnl   PHP_ADD_LIBRARY_WITH_PATH($LIBNAME, $%EXTNAMECAPS%_DIR/$PHP_LIBDIR, %EXTNAMECAPS%_SHARED_LIBADD)
-  dnl   AC_DEFINE(HAVE_%EXTNAMECAPS%LIB,1,[ ])
+  dnl   AC_DEFINE(HAVE_%EXTNAMECAPS%_FEATURE, 1, [ ])
   dnl ],[
-  dnl   AC_MSG_ERROR([wrong %EXTNAME% lib version or lib not found])
+  dnl   AC_MSG_ERROR([FEATURE not supported by your %EXTNAME% library.])
   dnl ],[
   dnl   -L$%EXTNAMECAPS%_DIR/$PHP_LIBDIR -lm
   dnl ])
-- 
2.50.1