From 72297bb71e3b0dd420c94fa5ed90038e445334d8 Mon Sep 17 00:00:00 2001 From: Guido van Rossum Date: Fri, 18 Oct 2002 13:41:47 +0000 Subject: [PATCH] Fix memory leak in add_subclass() found by NealN with valgrind. Will backport. --- Objects/typeobject.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Objects/typeobject.c b/Objects/typeobject.c index ed5b82951a..cc60d6c6af 100644 --- a/Objects/typeobject.c +++ b/Objects/typeobject.c @@ -2468,8 +2468,11 @@ add_subclass(PyTypeObject *base, PyTypeObject *type) while (--i >= 0) { ref = PyList_GET_ITEM(list, i); assert(PyWeakref_CheckRef(ref)); - if (PyWeakref_GET_OBJECT(ref) == Py_None) - return PyList_SetItem(list, i, new); + if (PyWeakref_GET_OBJECT(ref) == Py_None) { + i = PyList_SetItem(list, i, new); + Py_DECREF(new); + return i; + } } i = PyList_Append(list, new); Py_DECREF(new); -- 2.40.0