From 71bcb09b8fd0331c9f80ddfd6856d59e7d033d09 Mon Sep 17 00:00:00 2001 From: Devang Patel Date: Wed, 24 Oct 2007 00:32:16 +0000 Subject: [PATCH] Add notes. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@43282 91177308-0d34-0410-b5e6-96231b3b80d8 --- CodeGen/CodeGenTypes.cpp | 2 ++ CodeGen/CodeGenTypes.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/CodeGen/CodeGenTypes.cpp b/CodeGen/CodeGenTypes.cpp index 4aaf13f549..04394e38fe 100644 --- a/CodeGen/CodeGenTypes.cpp +++ b/CodeGen/CodeGenTypes.cpp @@ -176,6 +176,8 @@ const llvm::Type *CodeGenTypes::ConvertType(QualType T) { return OpaqueI->second; // Create new OpaqueType now for later use. + // FIXME: This creates a lot of opaque types, most of which are not needed. + // Reevaluate this when performance analyis finds tons of opaque types. llvm::OpaqueType *OpaqueTy = llvm::OpaqueType::get(); RecordTypesToResolve[RD] = OpaqueTy; diff --git a/CodeGen/CodeGenTypes.h b/CodeGen/CodeGenTypes.h index f149fb801d..7ab3afe2e1 100644 --- a/CodeGen/CodeGenTypes.h +++ b/CodeGen/CodeGenTypes.h @@ -94,6 +94,8 @@ class CodeGenTypes { /// RecordLayouts - This maps llvm struct type with corresponding /// record layout info. + /// FIXME : If RecordLayoutInfo is less than 16 bytes then use + /// inline it in the map. llvm::DenseMap RecordLayouts; /// FieldInfo - This maps struct field with corresponding llvm struct type -- 2.40.0