From 71a8d8cb100204ae3494852ccb2fff4977084f4a Mon Sep 17 00:00:00 2001 From: Fariborz Jahanian Date: Thu, 21 Nov 2013 00:39:36 +0000 Subject: [PATCH] ObjectiveC. Allow toll free bridge cast warnings outside ARC and in objectiveC/ObjectiveC++ MRR mode as well. // rdar://15454846 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@195288 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/clang/Sema/Sema.h | 2 + lib/Sema/SemaCast.cpp | 5 + lib/Sema/SemaExprObjC.cpp | 21 +-- test/SemaObjC/objcbridge-attribute-arc.m | 139 ++++++++++++++++++++ test/SemaObjC/objcbridge-attribute.m | 19 +-- test/SemaObjCXX/objcbridge-attribute-arc.mm | 139 ++++++++++++++++++++ test/SemaObjCXX/objcbridge-attribute.mm | 128 ++++++++++++++++++ 7 files changed, 429 insertions(+), 24 deletions(-) create mode 100644 test/SemaObjC/objcbridge-attribute-arc.m create mode 100644 test/SemaObjCXX/objcbridge-attribute-arc.mm create mode 100644 test/SemaObjCXX/objcbridge-attribute.mm diff --git a/include/clang/Sema/Sema.h b/include/clang/Sema/Sema.h index ed285832c6..300619b389 100644 --- a/include/clang/Sema/Sema.h +++ b/include/clang/Sema/Sema.h @@ -6865,6 +6865,8 @@ public: SourceLocation RParenLoc, Expr *SubExpr); + void CheckTollFreeBridgeCast(QualType castType, Expr *castExpr); + bool checkInitMethod(ObjCMethodDecl *method, QualType receiverTypeIfCall); /// \brief Check whether the given new method is a valid override of the diff --git a/lib/Sema/SemaCast.cpp b/lib/Sema/SemaCast.cpp index ba00b712aa..8662125560 100644 --- a/lib/Sema/SemaCast.cpp +++ b/lib/Sema/SemaCast.cpp @@ -2074,6 +2074,8 @@ void CastOperation::CheckCXXCStyleCast(bool FunctionalStyle, if (Self.getLangOpts().ObjCAutoRefCount && tcr == TC_Success) checkObjCARCConversion(CCK); + else if (Self.getLangOpts().ObjC1 && tcr == TC_Success) + Self.CheckTollFreeBridgeCast(DestType, SrcExpr.get()); if (tcr != TC_Success && msg != 0) { if (SrcExpr.get()->getType() == Self.Context.OverloadTy) { @@ -2319,6 +2321,9 @@ void CastOperation::CheckCStyleCast() { return; } } + else if (Self.getLangOpts().ObjC1) + Self.CheckTollFreeBridgeCast(DestType, SrcExpr.get()); + DiagnoseCastOfObjCSEL(Self, SrcExpr, DestType); DiagnoseBadFunctionCast(Self, SrcExpr, DestType); Kind = Self.PrepareScalarCast(SrcExpr, DestType); diff --git a/lib/Sema/SemaExprObjC.cpp b/lib/Sema/SemaExprObjC.cpp index 65f584f657..a906e2e9f9 100644 --- a/lib/Sema/SemaExprObjC.cpp +++ b/lib/Sema/SemaExprObjC.cpp @@ -3285,6 +3285,16 @@ static bool CheckObjCBridgeCFCast(Sema &S, QualType castType, Expr *castExpr) { return false; } +void Sema::CheckTollFreeBridgeCast(QualType castType, Expr *castExpr) { + // warn in presense of __bridge casting to or from a toll free bridge cast. + ARCConversionTypeClass exprACTC = classifyTypeForARCConversion(castExpr->getType()); + ARCConversionTypeClass castACTC = classifyTypeForARCConversion(castType); + if (castACTC == ACTC_retainable && exprACTC == ACTC_coreFoundation) + (void)CheckObjCBridgeNSCast(*this, castType, castExpr); + else if (castACTC == ACTC_coreFoundation && exprACTC == ACTC_retainable) + (void)CheckObjCBridgeCFCast(*this, castType, castExpr); +} + Sema::ARCConversionResult Sema::CheckObjCARCConversion(SourceRange castRange, QualType castType, Expr *&castExpr, CheckedConversionKind CCK, @@ -3617,15 +3627,8 @@ ExprResult Sema::ActOnObjCBridgedCast(Scope *S, Expr *SubExpr) { TypeSourceInfo *TSInfo = 0; QualType T = GetTypeFromParser(Type, &TSInfo); - if (Kind == OBC_Bridge) { - // warn in presense of __bridge casting to or from a toll free bridge cast. - ARCConversionTypeClass exprACTC = classifyTypeForARCConversion(SubExpr->getType()); - ARCConversionTypeClass castACTC = classifyTypeForARCConversion(T); - if (castACTC == ACTC_retainable && exprACTC == ACTC_coreFoundation) - (void)CheckObjCBridgeNSCast(*this, T, SubExpr); - else if (castACTC == ACTC_coreFoundation && exprACTC == ACTC_retainable) - (void)CheckObjCBridgeCFCast(*this, T, SubExpr); - } + if (Kind == OBC_Bridge) + CheckTollFreeBridgeCast(T, SubExpr); if (!TSInfo) TSInfo = Context.getTrivialTypeSourceInfo(T, LParenLoc); return BuildObjCBridgedCast(LParenLoc, Kind, BridgeKeywordLoc, TSInfo, diff --git a/test/SemaObjC/objcbridge-attribute-arc.m b/test/SemaObjC/objcbridge-attribute-arc.m new file mode 100644 index 0000000000..9b67523a50 --- /dev/null +++ b/test/SemaObjC/objcbridge-attribute-arc.m @@ -0,0 +1,139 @@ +// RUN: %clang_cc1 -fsyntax-only -x objective-c -fobjc-arc -verify -Wno-objc-root-class %s +// rdar://15454846 + +typedef struct __attribute__ ((objc_bridge(NSError))) __CFErrorRef * CFErrorRef; // expected-note 7 {{declared here}} + +typedef struct __attribute__ ((objc_bridge(MyError))) __CFMyErrorRef * CFMyErrorRef; // expected-note 3 {{declared here}} + +typedef struct __attribute__((objc_bridge(12))) __CFMyColor *CFMyColorRef; // expected-error {{parameter of 'objc_bridge' attribute must be a single name of an Objective-C class}} + +typedef struct __attribute__ ((objc_bridge)) __CFArray *CFArrayRef; // expected-error {{parameter of 'objc_bridge' attribute must be a single name of an Objective-C class}} + +typedef void * __attribute__ ((objc_bridge(NSURL))) CFURLRef; // expected-error {{'objc_bridge' attribute only applies to struct or union}} + +typedef void * CFStringRef __attribute__ ((objc_bridge(NSString))); // expected-error {{'objc_bridge' attribute only applies to struct or union}} + +typedef struct __attribute__((objc_bridge(NSLocale, NSError))) __CFLocale *CFLocaleRef;// expected-error {{use of undeclared identifier 'NSError'}} + +typedef struct __CFData __attribute__((objc_bridge(NSData))) CFDataRef; // expected-error {{'objc_bridge' attribute only applies to struct or union}} + +typedef struct __attribute__((objc_bridge(NSDictionary))) __CFDictionary * CFDictionaryRef; + +typedef struct __CFSetRef * CFSetRef __attribute__((objc_bridge(NSSet))); // expected-error {{'objc_bridge' attribute only applies to struct or union}}; + +typedef union __CFUColor __attribute__((objc_bridge(NSUColor))) * CFUColorRef; // expected-error {{'objc_bridge' attribute only applies to struct or union}}; + +typedef union __CFUColor __attribute__((objc_bridge(NSUColor))) *CFUColor1Ref; // expected-error {{'objc_bridge' attribute only applies to struct or union}}; + +typedef union __attribute__((objc_bridge(NSUColor))) __CFUPrimeColor XXX; +typedef XXX *CFUColor2Ref; + +@interface I +{ + __attribute__((objc_bridge(NSError))) void * color; // expected-error {{'objc_bridge' attribute only applies to struct or union}}; +} +@end + +@protocol NSTesting @end +@class NSString; + +typedef struct __attribute__((objc_bridge(NSTesting))) __CFError *CFTestingRef; // expected-note {{declared here}} + +id Test1(CFTestingRef cf) { + return (NSString *)cf; // expected-error {{CF object of type 'CFTestingRef' (aka 'struct __CFError *') is bridged to 'NSTesting', which is not an Objective-C class}} +} + +typedef CFErrorRef CFErrorRef1; + +typedef CFErrorRef1 CFErrorRef2; // expected-note 2 {{declared here}} + +@protocol P1 @end +@protocol P2 @end +@protocol P3 @end +@protocol P4 @end +@protocol P5 @end + +@interface NSError @end // expected-note 7 {{declared here}} + +@interface MyError : NSError // expected-note 3 {{declared here}} +@end + +@interface NSUColor @end + +@class NSString; + +void Test2(CFErrorRef2 cf, NSError *ns, NSString *str, Class c, CFUColor2Ref cf2) { + (void)(NSString *)cf; // expected-warning {{'CFErrorRef2' (aka 'struct __CFErrorRef *') bridges to NSError, not 'NSString'}} + (void)(NSError *)cf; // okay + (void)(MyError*)cf; // okay, + (void)(NSUColor *)cf2; // okay + (void)(CFErrorRef)ns; // okay + (void)(CFErrorRef)str; // expected-warning {{'NSString' cannot bridge to 'CFErrorRef' (aka 'struct __CFErrorRef *')}} + (void)(Class)cf; // expected-warning {{'CFErrorRef2' (aka 'struct __CFErrorRef *') bridges to NSError, not 'Class'}} + (void)(CFErrorRef)c; // expected-warning {{'Class' cannot bridge to 'CFErrorRef'}} +} + + +void Test3(CFErrorRef cf, NSError *ns) { + (void)(id)cf; // okay + (void)(id)cf; // okay + (void)(id)cf; // expected-warning {{'CFErrorRef' (aka 'struct __CFErrorRef *') bridges to NSError, not 'id'}} +} + +void Test4(CFMyErrorRef cf) { + (void)(id)cf; // okay + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // expected-warning {{'CFMyErrorRef' (aka 'struct __CFMyErrorRef *') bridges to MyError, not 'id'}} +} + +void Test5(id P123, id ID, id P1234, id P12, id P23) { + (void)(CFErrorRef)ID; // ok + (void)(CFErrorRef)P123; // ok + (void)(CFErrorRef)P1234; // ok + (void)(CFErrorRef)P12; // expected-warning {{'id' cannot bridge to 'CFErrorRef' (aka 'struct __CFErrorRef *')}} + (void)(CFErrorRef)P23; // expected-warning {{'id' cannot bridge to 'CFErrorRef' (aka 'struct __CFErrorRef *')}} +} + +void Test6(id P123, id ID, id P1234, id P12, id P23) { + + (void)(CFMyErrorRef)ID; // ok + (void)(CFMyErrorRef)P123; // ok + (void)(CFMyErrorRef)P1234; // ok + (void)(CFMyErrorRef)P12; // expected-warning {{'id' cannot bridge to 'CFMyErrorRef' (aka 'struct __CFMyErrorRef *')}} + (void)(CFMyErrorRef)P23; // expected-warning {{'id' cannot bridge to 'CFMyErrorRef' (aka 'struct __CFMyErrorRef *')}} +} + +typedef struct __attribute__ ((objc_bridge(MyPersonalError))) __CFMyPersonalErrorRef * CFMyPersonalErrorRef; // expected-note 4 {{declared here}} + +@interface MyPersonalError : NSError // expected-note 4 {{declared here}} +@end + +void Test7(id P123, id ID, id P1234, id P12, id P23) { + (void)(CFMyPersonalErrorRef)ID; // ok + (void)(CFMyPersonalErrorRef)P123; // expected-warning {{'id' cannot bridge to 'CFMyPersonalErrorRef' (aka 'struct __CFMyPersonalErrorRef *')}} + (void)(CFMyPersonalErrorRef)P1234; // ok + (void)(CFMyPersonalErrorRef)P12; // expected-warning {{'id' cannot bridge to 'CFMyPersonalErrorRef' (aka 'struct __CFMyPersonalErrorRef *')}} + (void)(CFMyPersonalErrorRef)P23; // expected-warning {{'id' cannot bridge to 'CFMyPersonalErrorRef' (aka 'struct __CFMyPersonalErrorRef *')}} +} + +void Test8(CFMyPersonalErrorRef cf) { + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // expected-warning {{'CFMyPersonalErrorRef' (aka 'struct __CFMyPersonalErrorRef *') bridges to MyPersonalError, not 'id'}} +} + +void Test9(CFErrorRef2 cf, NSError *ns, NSString *str, Class c, CFUColor2Ref cf2) { + (void)(__bridge NSString *)cf; // expected-warning {{'CFErrorRef2' (aka 'struct __CFErrorRef *') bridges to NSError, not 'NSString'}} + (void)(__bridge NSError *)cf; // okay + (void)(__bridge MyError*)cf; // okay, + (void)(__bridge NSUColor *)cf2; // okay + (void)(__bridge CFErrorRef)ns; // okay + (void)(__bridge CFErrorRef)str; // expected-warning {{'NSString' cannot bridge to 'CFErrorRef' (aka 'struct __CFErrorRef *')}} + (void)(__bridge Class)cf; // expected-warning {{'CFErrorRef2' (aka 'struct __CFErrorRef *') bridges to NSError, not 'Class'}} + (void)(__bridge CFErrorRef)c; // expected-warning {{'__unsafe_unretained Class' cannot bridge to 'CFErrorRef' (aka 'struct __CFErrorRef *')}} +} diff --git a/test/SemaObjC/objcbridge-attribute.m b/test/SemaObjC/objcbridge-attribute.m index 67e09e5fb1..8be4b2d5f0 100644 --- a/test/SemaObjC/objcbridge-attribute.m +++ b/test/SemaObjC/objcbridge-attribute.m @@ -1,7 +1,7 @@ -// RUN: %clang_cc1 -fsyntax-only -fobjc-arc -verify -Wno-objc-root-class %s +// RUN: %clang_cc1 -fsyntax-only -verify -Wno-objc-root-class %s // rdar://15454846 -typedef struct __attribute__ ((objc_bridge(NSError))) __CFErrorRef * CFErrorRef; // expected-note 7 {{declared here}} +typedef struct __attribute__ ((objc_bridge(NSError))) __CFErrorRef * CFErrorRef; // expected-note 5 {{declared here}} typedef struct __attribute__ ((objc_bridge(MyError))) __CFMyErrorRef * CFMyErrorRef; // expected-note 3 {{declared here}} @@ -45,7 +45,7 @@ id Test1(CFTestingRef cf) { typedef CFErrorRef CFErrorRef1; -typedef CFErrorRef1 CFErrorRef2; // expected-note 2 {{declared here}} +typedef CFErrorRef1 CFErrorRef2; // expected-note {{declared here}} @protocol P1 @end @protocol P2 @end @@ -53,7 +53,7 @@ typedef CFErrorRef1 CFErrorRef2; // expected-note 2 {{declared here}} @protocol P4 @end @protocol P5 @end -@interface NSError @end // expected-note 7 {{declared here}} +@interface NSError @end // expected-note 5 {{declared here}} @interface MyError : NSError // expected-note 3 {{declared here}} @end @@ -126,14 +126,3 @@ void Test8(CFMyPersonalErrorRef cf) { (void)(id)cf; // ok (void)(id)cf; // expected-warning {{'CFMyPersonalErrorRef' (aka 'struct __CFMyPersonalErrorRef *') bridges to MyPersonalError, not 'id'}} } - -void Test9(CFErrorRef2 cf, NSError *ns, NSString *str, Class c, CFUColor2Ref cf2) { - (void)(__bridge NSString *)cf; // expected-warning {{'CFErrorRef2' (aka 'struct __CFErrorRef *') bridges to NSError, not 'NSString'}} - (void)(__bridge NSError *)cf; // okay - (void)(__bridge MyError*)cf; // okay, - (void)(__bridge NSUColor *)cf2; // okay - (void)(__bridge CFErrorRef)ns; // okay - (void)(__bridge CFErrorRef)str; // expected-warning {{'NSString' cannot bridge to 'CFErrorRef' (aka 'struct __CFErrorRef *')}} - (void)(__bridge Class)cf; // expected-warning {{'CFErrorRef2' (aka 'struct __CFErrorRef *') bridges to NSError, not 'Class'}} - (void)(__bridge CFErrorRef)c; // expected-warning {{'__unsafe_unretained Class' cannot bridge to 'CFErrorRef' (aka 'struct __CFErrorRef *')}} -} diff --git a/test/SemaObjCXX/objcbridge-attribute-arc.mm b/test/SemaObjCXX/objcbridge-attribute-arc.mm new file mode 100644 index 0000000000..fa67dfb72d --- /dev/null +++ b/test/SemaObjCXX/objcbridge-attribute-arc.mm @@ -0,0 +1,139 @@ +// RUN: %clang_cc1 -fsyntax-only -x objective-c++ -fobjc-arc -verify -Wno-objc-root-class %s +// rdar://15454846 + +typedef struct __attribute__ ((objc_bridge(NSError))) __CFErrorRef * CFErrorRef; // expected-note 7 {{declared here}} + +typedef struct __attribute__ ((objc_bridge(MyError))) __CFMyErrorRef * CFMyErrorRef; // expected-note 3 {{declared here}} + +typedef struct __attribute__((objc_bridge(12))) __CFMyColor *CFMyColorRef; // expected-error {{parameter of 'objc_bridge' attribute must be a single name of an Objective-C class}} + +typedef struct __attribute__ ((objc_bridge)) __CFArray *CFArrayRef; // expected-error {{parameter of 'objc_bridge' attribute must be a single name of an Objective-C class}} + +typedef void * __attribute__ ((objc_bridge(NSURL))) CFURLRef; // expected-error {{'objc_bridge' attribute only applies to struct, union or class}} + +typedef void * CFStringRef __attribute__ ((objc_bridge(NSString))); // expected-error {{'objc_bridge' attribute only applies to struct, union or class}} + +typedef struct __attribute__((objc_bridge(NSLocale, NSError))) __CFLocale *CFLocaleRef;// expected-error {{use of undeclared identifier 'NSError'}} + +typedef struct __CFData __attribute__((objc_bridge(NSData))) CFDataRef; // expected-error {{'objc_bridge' attribute only applies to struct, union or class}} + +typedef struct __attribute__((objc_bridge(NSDictionary))) __CFDictionary * CFDictionaryRef; + +typedef struct __CFSetRef * CFSetRef __attribute__((objc_bridge(NSSet))); // expected-error {{'objc_bridge' attribute only applies to struct, union or class}}; + +typedef union __CFUColor __attribute__((objc_bridge(NSUColor))) * CFUColorRef; // expected-error {{'objc_bridge' attribute only applies to struct, union or class}}; + +typedef union __CFUColor __attribute__((objc_bridge(NSUColor))) *CFUColor1Ref; // expected-error {{'objc_bridge' attribute only applies to struct, union or class}}; + +typedef union __attribute__((objc_bridge(NSUColor))) __CFUPrimeColor XXX; +typedef XXX *CFUColor2Ref; + +@interface I +{ + __attribute__((objc_bridge(NSError))) void * color; // expected-error {{'objc_bridge' attribute only applies to struct, union or class}}; +} +@end + +@protocol NSTesting @end +@class NSString; + +typedef struct __attribute__((objc_bridge(NSTesting))) __CFError *CFTestingRef; // expected-note {{declared here}} + +id Test1(CFTestingRef cf) { + return (NSString *)cf; // expected-error {{CF object of type 'CFTestingRef' (aka '__CFError *') is bridged to 'NSTesting', which is not an Objective-C class}} +} + +typedef CFErrorRef CFErrorRef1; + +typedef CFErrorRef1 CFErrorRef2; // expected-note 2 {{declared here}} + +@protocol P1 @end +@protocol P2 @end +@protocol P3 @end +@protocol P4 @end +@protocol P5 @end + +@interface NSError @end // expected-note 7 {{declared here}} + +@interface MyError : NSError // expected-note 3 {{declared here}} +@end + +@interface NSUColor @end + +@class NSString; + +void Test2(CFErrorRef2 cf, NSError *ns, NSString *str, Class c, CFUColor2Ref cf2) { + (void)(NSString *)cf; // expected-warning {{'CFErrorRef2' (aka '__CFErrorRef *') bridges to NSError, not 'NSString'}} + (void)(NSError *)cf; // okay + (void)(MyError*)cf; // okay, + (void)(NSUColor *)cf2; // okay + (void)(CFErrorRef)ns; // okay + (void)(CFErrorRef)str; // expected-warning {{'NSString' cannot bridge to 'CFErrorRef' (aka '__CFErrorRef *')}} + (void)(Class)cf; // expected-warning {{'CFErrorRef2' (aka '__CFErrorRef *') bridges to NSError, not 'Class'}} + (void)(CFErrorRef)c; // expected-warning {{'Class' cannot bridge to 'CFErrorRef'}} +} + + +void Test3(CFErrorRef cf, NSError *ns) { + (void)(id)cf; // okay + (void)(id)cf; // okay + (void)(id)cf; // expected-warning {{'CFErrorRef' (aka '__CFErrorRef *') bridges to NSError, not 'id'}} +} + +void Test4(CFMyErrorRef cf) { + (void)(id)cf; // okay + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // expected-warning {{'CFMyErrorRef' (aka '__CFMyErrorRef *') bridges to MyError, not 'id'}} +} + +void Test5(id P123, id ID, id P1234, id P12, id P23) { + (void)(CFErrorRef)ID; // ok + (void)(CFErrorRef)P123; // ok + (void)(CFErrorRef)P1234; // ok + (void)(CFErrorRef)P12; // expected-warning {{'id' cannot bridge to 'CFErrorRef' (aka '__CFErrorRef *')}} + (void)(CFErrorRef)P23; // expected-warning {{'id' cannot bridge to 'CFErrorRef' (aka '__CFErrorRef *')}} +} + +void Test6(id P123, id ID, id P1234, id P12, id P23) { + + (void)(CFMyErrorRef)ID; // ok + (void)(CFMyErrorRef)P123; // ok + (void)(CFMyErrorRef)P1234; // ok + (void)(CFMyErrorRef)P12; // expected-warning {{'id' cannot bridge to 'CFMyErrorRef' (aka '__CFMyErrorRef *')}} + (void)(CFMyErrorRef)P23; // expected-warning {{'id' cannot bridge to 'CFMyErrorRef' (aka '__CFMyErrorRef *')}} +} + +typedef struct __attribute__ ((objc_bridge(MyPersonalError))) __CFMyPersonalErrorRef * CFMyPersonalErrorRef; // expected-note 4 {{declared here}} + +@interface MyPersonalError : NSError // expected-note 4 {{declared here}} +@end + +void Test7(id P123, id ID, id P1234, id P12, id P23) { + (void)(CFMyPersonalErrorRef)ID; // ok + (void)(CFMyPersonalErrorRef)P123; // expected-warning {{'id' cannot bridge to 'CFMyPersonalErrorRef' (aka '__CFMyPersonalErrorRef *')}} + (void)(CFMyPersonalErrorRef)P1234; // ok + (void)(CFMyPersonalErrorRef)P12; // expected-warning {{'id' cannot bridge to 'CFMyPersonalErrorRef' (aka '__CFMyPersonalErrorRef *')}} + (void)(CFMyPersonalErrorRef)P23; // expected-warning {{'id' cannot bridge to 'CFMyPersonalErrorRef' (aka '__CFMyPersonalErrorRef *')}} +} + +void Test8(CFMyPersonalErrorRef cf) { + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // expected-warning {{'CFMyPersonalErrorRef' (aka '__CFMyPersonalErrorRef *') bridges to MyPersonalError, not 'id'}} +} + +void Test9(CFErrorRef2 cf, NSError *ns, NSString *str, Class c, CFUColor2Ref cf2) { + (void)(__bridge NSString *)cf; // expected-warning {{'CFErrorRef2' (aka '__CFErrorRef *') bridges to NSError, not 'NSString'}} + (void)(__bridge NSError *)cf; // okay + (void)(__bridge MyError*)cf; // okay, + (void)(__bridge NSUColor *)cf2; // okay + (void)(__bridge CFErrorRef)ns; // okay + (void)(__bridge CFErrorRef)str; // expected-warning {{'NSString' cannot bridge to 'CFErrorRef' (aka '__CFErrorRef *')}} + (void)(__bridge Class)cf; // expected-warning {{'CFErrorRef2' (aka '__CFErrorRef *') bridges to NSError, not 'Class'}} + (void)(__bridge CFErrorRef)c; // expected-warning {{'__unsafe_unretained Class' cannot bridge to 'CFErrorRef' (aka '__CFErrorRef *')}} +} diff --git a/test/SemaObjCXX/objcbridge-attribute.mm b/test/SemaObjCXX/objcbridge-attribute.mm new file mode 100644 index 0000000000..3e23cdbba4 --- /dev/null +++ b/test/SemaObjCXX/objcbridge-attribute.mm @@ -0,0 +1,128 @@ +// RUN: %clang_cc1 -fsyntax-only -x objective-c++ -verify -Wno-objc-root-class %s +// rdar://15454846 + +typedef struct __attribute__ ((objc_bridge(NSError))) __CFErrorRef * CFErrorRef; // expected-note 5 {{declared here}} + +typedef struct __attribute__ ((objc_bridge(MyError))) __CFMyErrorRef * CFMyErrorRef; // expected-note 3 {{declared here}} + +typedef struct __attribute__((objc_bridge(12))) __CFMyColor *CFMyColorRef; // expected-error {{parameter of 'objc_bridge' attribute must be a single name of an Objective-C class}} + +typedef struct __attribute__ ((objc_bridge)) __CFArray *CFArrayRef; // expected-error {{parameter of 'objc_bridge' attribute must be a single name of an Objective-C class}} + +typedef void * __attribute__ ((objc_bridge(NSURL))) CFURLRef; // expected-error {{'objc_bridge' attribute only applies to struct, union or class}} + +typedef void * CFStringRef __attribute__ ((objc_bridge(NSString))); // expected-error {{'objc_bridge' attribute only applies to struct, union or class}} + +typedef struct __attribute__((objc_bridge(NSLocale, NSError))) __CFLocale *CFLocaleRef;// expected-error {{use of undeclared identifier 'NSError'}} + +typedef struct __CFData __attribute__((objc_bridge(NSData))) CFDataRef; // expected-error {{'objc_bridge' attribute only applies to struct, union or class}} + +typedef struct __attribute__((objc_bridge(NSDictionary))) __CFDictionary * CFDictionaryRef; + +typedef struct __CFSetRef * CFSetRef __attribute__((objc_bridge(NSSet))); // expected-error {{'objc_bridge' attribute only applies to struct, union or class}}; + +typedef union __CFUColor __attribute__((objc_bridge(NSUColor))) * CFUColorRef; // expected-error {{'objc_bridge' attribute only applies to struct, union or class}}; + +typedef union __CFUColor __attribute__((objc_bridge(NSUColor))) *CFUColor1Ref; // expected-error {{'objc_bridge' attribute only applies to struct, union or class}}; + +typedef union __attribute__((objc_bridge(NSUColor))) __CFUPrimeColor XXX; +typedef XXX *CFUColor2Ref; + +@interface I +{ + __attribute__((objc_bridge(NSError))) void * color; // expected-error {{'objc_bridge' attribute only applies to struct, union or class}}; +} +@end + +@protocol NSTesting @end +@class NSString; + +typedef struct __attribute__((objc_bridge(NSTesting))) __CFError *CFTestingRef; // expected-note {{declared here}} + +id Test1(CFTestingRef cf) { + return (NSString *)cf; // expected-error {{CF object of type 'CFTestingRef' (aka '__CFError *') is bridged to 'NSTesting', which is not an Objective-C class}} +} + +typedef CFErrorRef CFErrorRef1; + +typedef CFErrorRef1 CFErrorRef2; // expected-note {{declared here}} + +@protocol P1 @end +@protocol P2 @end +@protocol P3 @end +@protocol P4 @end +@protocol P5 @end + +@interface NSError @end // expected-note 5 {{declared here}} + +@interface MyError : NSError // expected-note 3 {{declared here}} +@end + +@interface NSUColor @end + +@class NSString; + +void Test2(CFErrorRef2 cf, NSError *ns, NSString *str, Class c, CFUColor2Ref cf2) { + (void)(NSString *)cf; // expected-warning {{'CFErrorRef2' (aka '__CFErrorRef *') bridges to NSError, not 'NSString'}} + (void)(NSError *)cf; // okay + (void)(MyError*)cf; // okay, + (void)(NSUColor *)cf2; // okay + (void)(CFErrorRef)ns; // okay + (void)(CFErrorRef)str; // expected-warning {{'NSString' cannot bridge to 'CFErrorRef' (aka '__CFErrorRef *')}} + (void)(Class)cf; // expected-warning {{'CFErrorRef2' (aka '__CFErrorRef *') bridges to NSError, not 'Class'}} + (void)(CFErrorRef)c; // expected-warning {{'Class' cannot bridge to 'CFErrorRef'}} +} + + +void Test3(CFErrorRef cf, NSError *ns) { + (void)(id)cf; // okay + (void)(id)cf; // okay + (void)(id)cf; // expected-warning {{'CFErrorRef' (aka '__CFErrorRef *') bridges to NSError, not 'id'}} +} + +void Test4(CFMyErrorRef cf) { + (void)(id)cf; // okay + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // expected-warning {{'CFMyErrorRef' (aka '__CFMyErrorRef *') bridges to MyError, not 'id'}} +} + +void Test5(id P123, id ID, id P1234, id P12, id P23) { + (void)(CFErrorRef)ID; // ok + (void)(CFErrorRef)P123; // ok + (void)(CFErrorRef)P1234; // ok + (void)(CFErrorRef)P12; // expected-warning {{'id' cannot bridge to 'CFErrorRef' (aka '__CFErrorRef *')}} + (void)(CFErrorRef)P23; // expected-warning {{'id' cannot bridge to 'CFErrorRef' (aka '__CFErrorRef *')}} +} + +void Test6(id P123, id ID, id P1234, id P12, id P23) { + + (void)(CFMyErrorRef)ID; // ok + (void)(CFMyErrorRef)P123; // ok + (void)(CFMyErrorRef)P1234; // ok + (void)(CFMyErrorRef)P12; // expected-warning {{'id' cannot bridge to 'CFMyErrorRef' (aka '__CFMyErrorRef *')}} + (void)(CFMyErrorRef)P23; // expected-warning {{'id' cannot bridge to 'CFMyErrorRef' (aka '__CFMyErrorRef *')}} +} + +typedef struct __attribute__ ((objc_bridge(MyPersonalError))) __CFMyPersonalErrorRef * CFMyPersonalErrorRef; // expected-note 4 {{declared here}} + +@interface MyPersonalError : NSError // expected-note 4 {{declared here}} +@end + +void Test7(id P123, id ID, id P1234, id P12, id P23) { + (void)(CFMyPersonalErrorRef)ID; // ok + (void)(CFMyPersonalErrorRef)P123; // expected-warning {{'id' cannot bridge to 'CFMyPersonalErrorRef' (aka '__CFMyPersonalErrorRef *')}} + (void)(CFMyPersonalErrorRef)P1234; // ok + (void)(CFMyPersonalErrorRef)P12; // expected-warning {{'id' cannot bridge to 'CFMyPersonalErrorRef' (aka '__CFMyPersonalErrorRef *')}} + (void)(CFMyPersonalErrorRef)P23; // expected-warning {{'id' cannot bridge to 'CFMyPersonalErrorRef' (aka '__CFMyPersonalErrorRef *')}} +} + +void Test8(CFMyPersonalErrorRef cf) { + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // ok + (void)(id)cf; // expected-warning {{'CFMyPersonalErrorRef' (aka '__CFMyPersonalErrorRef *') bridges to MyPersonalError, not 'id'}} +} -- 2.40.0