From 70fd03e461ee961597280280f60fef79c37562ad Mon Sep 17 00:00:00 2001 From: Jim Warner Date: Mon, 29 Jun 2020 00:00:00 -0500 Subject: [PATCH] library: size two read buffers with manifest constants The meminfo & vmstat file read buffers are now defined through symbolic constants next to the symbolic names. [ recent attention to the /proc/stat buffer size led ] [ to this (hopefully) better approach to definitions ] Reference(s): commit 81f4a6acdf204c5c898fa707e285cdbd2389150e Signed-off-by: Jim Warner --- proc/meminfo.c | 5 +++-- proc/vmstat.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/proc/meminfo.c b/proc/meminfo.c index 668dcb61..73035877 100644 --- a/proc/meminfo.c +++ b/proc/meminfo.c @@ -32,7 +32,8 @@ #include -#define MEMINFO_FILE "/proc/meminfo" +#define MEMINFO_FILE "/proc/meminfo" +#define MEMINFO_BUFF 8192 struct meminfo_data { @@ -606,7 +607,7 @@ static int meminfo_read_failed ( /* a 'memory history reference' macro for readability, so we can focus the field names ... */ #define mHr(f) info->hist.new. f - char buf[8192]; + char buf[MEMINFO_BUFF]; char *head, *tail; int size; unsigned long *valptr; diff --git a/proc/vmstat.c b/proc/vmstat.c index ab404bdf..36a89232 100644 --- a/proc/vmstat.c +++ b/proc/vmstat.c @@ -38,7 +38,8 @@ #include -#define VMSTAT_FILE "/proc/vmstat" +#define VMSTAT_FILE "/proc/vmstat" +#define VMSTAT_BUFF 8192 /* * Perhaps someday we'll all learn what is in these fields. But | @@ -1067,7 +1068,7 @@ static int vmstat_make_hash_failed ( static int vmstat_read_failed ( struct vmstat_info *info) { - char buf[8192]; + char buf[VMSTAT_BUFF]; char *head, *tail; int size; unsigned long *valptr; -- 2.40.0