From 70101ce87ff1d73ac90e4d99a3af0ae509e5934f Mon Sep 17 00:00:00 2001
From: Mike Stump <mrs@apple.com>
Date: Thu, 6 Aug 2009 18:05:22 +0000
Subject: [PATCH] Layout the primary base first in the vtable.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@78327 91177308-0d34-0410-b5e6-96231b3b80d8
---
 lib/CodeGen/CGCXX.cpp    | 35 ++++++++++++++---------------------
 test/CodeGenCXX/virt.cpp |  9 ++++-----
 2 files changed, 18 insertions(+), 26 deletions(-)

diff --git a/lib/CodeGen/CGCXX.cpp b/lib/CodeGen/CGCXX.cpp
index 7cf397fc07..567c58373c 100644
--- a/lib/CodeGen/CGCXX.cpp
+++ b/lib/CodeGen/CGCXX.cpp
@@ -576,6 +576,18 @@ llvm::Value *CodeGenFunction::GenerateVtable(const CXXRecordDecl *RD) {
   const ASTRecordLayout &Layout = getContext().getASTRecordLayout(RD);
   const CXXRecordDecl *PrimaryBase = Layout.getPrimaryBase();
 
+  // The primary base comes first.
+  if (PrimaryBase)
+    GenerateVtableForBase(PrimaryBase, methods);
+  for (meth_iter mi = RD->method_begin(), me = RD->method_end(); mi != me;
+       ++mi) {
+    if (mi->isVirtual()) {
+      m = CGM.GetAddrOfFunction(GlobalDecl(*mi));
+      m = llvm::ConstantExpr::getBitCast(m, Ptr8Ty);
+      methods.push_back(m);
+    }
+  }
+
   for (CXXRecordDecl::base_class_const_iterator i = RD->bases_begin(),
          e = RD->bases_end(); i != e; ++i) {
     if (i->isVirtual())
@@ -591,29 +603,10 @@ llvm::Value *CodeGenFunction::GenerateVtable(const CXXRecordDecl *RD) {
       // FIXME: GenerateRtti for Base in RD.
       m = llvm::Constant::getNullValue(Ptr8Ty);
       methods.push_back(m);
-    }
-    GenerateVtableForBase(Base, methods);
-    if (PrimaryBase == Base) {
-      for (meth_iter mi = RD->method_begin(), me = RD->method_end(); mi != me;
-           ++mi) {
-        if (mi->isVirtual()) {
-          m = CGM.GetAddrOfFunction(GlobalDecl(*mi));
-          m = llvm::ConstantExpr::getBitCast(m, Ptr8Ty);
-          methods.push_back(m);
-        }
-      }
-    }
-  }
-  if (PrimaryBase == 0) {
-    for (meth_iter mi = RD->method_begin(), me = RD->method_end(); mi != me;
-         ++mi) {
-      if (mi->isVirtual()) {
-        m = CGM.GetAddrOfFunction(GlobalDecl(*mi));
-        m = llvm::ConstantExpr::getBitCast(m, Ptr8Ty);
-        methods.push_back(m);
-      }
+      GenerateVtableForBase(Base, methods);
     }
   }
+
   // FIXME: finish layout for virtual bases
   // FIXME: audit indirect virtual bases
   for (CXXRecordDecl::base_class_const_iterator i = RD->vbases_begin(),
diff --git a/test/CodeGenCXX/virt.cpp b/test/CodeGenCXX/virt.cpp
index f462b0e693..4ba52bc7ff 100644
--- a/test/CodeGenCXX/virt.cpp
+++ b/test/CodeGenCXX/virt.cpp
@@ -123,8 +123,8 @@ int main() {
 // CHECK-LP32 .space 4
 // CHECK-LP32: .space 4
 // CHECK-LP32: .space 4
-// CHECK-LP32 .long __ZN1D3booEv
-// CHECK-LP32 .long __ZN1F3fooEv
+// CHECK-LP32: .long __ZN1D3booEv
+// CHECK-LP32: .long __ZN1F3fooEv
 // CHECK-LP32 .space 4
 // CHECK-LP32 .long -8
 // CHECK-LP32 .space 4
@@ -136,10 +136,9 @@ int main() {
 // CHECK-LP64 .space 8
 // CHECK-LP64: .space 8
 // CHECK-LP64: .space 8
-// CHECK-LP64 .quad __ZN1D3booEv
-// CHECK-LP64 .quad __ZN1F3fooEv
+// CHECK-LP64: .quad __ZN1D3booEv
+// CHECK-LP64: .quad __ZN1F3fooEv
 // CHECK-LP64 .space 8
 // CHECK-LP64 .space -16
 // CHECK-LP64 .space 8
 // CHECK-LP64: .quad __ZN2D13barEv
-
-- 
2.40.0