From 6e2333dfdf54f052fcf404086141e820da3af8fb Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Tue, 23 Aug 2016 00:25:01 +0200 Subject: [PATCH] PyEval_CallObjectWithKeywords() doesn't inc/decref Issue #27809: PyEval_CallObjectWithKeywords() doesn't increment temporary the reference counter of the args tuple (positional arguments). The caller already holds a strong reference to it. --- Python/ceval.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/Python/ceval.c b/Python/ceval.c index fd456ceed1..f9759f0f70 100644 --- a/Python/ceval.c +++ b/Python/ceval.c @@ -4580,8 +4580,6 @@ PyEval_MergeCompilerFlags(PyCompilerFlags *cf) PyObject * PyEval_CallObjectWithKeywords(PyObject *func, PyObject *args, PyObject *kwargs) { - PyObject *result; - #ifdef Py_DEBUG /* PyEval_CallObjectWithKeywords() must not be called with an exception set. It raises a new exception if parameters are invalid or if @@ -4605,11 +4603,7 @@ PyEval_CallObjectWithKeywords(PyObject *func, PyObject *args, PyObject *kwargs) return NULL; } - Py_INCREF(args); - result = PyObject_Call(func, args, kwargs); - Py_DECREF(args); - - return result; + return PyObject_Call(func, args, kwargs); } const char * -- 2.40.0