From 6d95ea199d7f94adac61eab6d2a38a114e9c7973 Mon Sep 17 00:00:00 2001 From: Moriyoshi Koizumi Date: Mon, 10 Feb 2003 20:18:08 +0000 Subject: [PATCH] Fixed possible snprintf problem # besides snprintf returns int value, not uint / size_t... --- main/SAPI.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/main/SAPI.c b/main/SAPI.c index 9657ba3a3f..dedd65c462 100644 --- a/main/SAPI.c +++ b/main/SAPI.c @@ -720,12 +720,12 @@ SAPI_API int sapi_send_headers(TSRMLS_D) if (call_user_function_ex(CG(function_table), NULL, &nm_zlib_get_coding_type, &uf_result, 0, NULL, 1, NULL TSRMLS_CC) != FAILURE && uf_result != NULL && Z_TYPE_P(uf_result) == IS_STRING) { char buf[128]; - uint len; + int len; assert(Z_STRVAL_P(uf_result) != NULL); len = snprintf(buf, sizeof(buf), "Content-Encoding: %s", Z_STRVAL_P(uf_result)); - if (sapi_add_header(buf, len, 1)==FAILURE) { + if (len <= 0 || sapi_add_header(buf, len, 1) == FAILURE) { return FAILURE; } if (sapi_add_header("Vary: Accept-Encoding", sizeof("Vary: Accept-Encoding") - 1, 1) == FAILURE) { -- 2.40.0