From 6cda3e604f2a2fa289cc9145719ba84461315e21 Mon Sep 17 00:00:00 2001 From: Douglas Gregor Date: Thu, 7 Mar 2013 22:38:24 +0000 Subject: [PATCH] When possible, move __block variables to the heap rather than copying them. Fixes . git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@176663 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaDecl.cpp | 8 ++++---- test/SemaCXX/blocks.cpp | 15 ++++++++++++++- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp index 82d216ee01..4fa790515d 100644 --- a/lib/Sema/SemaDecl.cpp +++ b/lib/Sema/SemaDecl.cpp @@ -7811,10 +7811,10 @@ void Sema::CheckCompleteVariableDeclaration(VarDecl *var) { if (type->isStructureOrClassType()) { SourceLocation poi = var->getLocation(); Expr *varRef =new (Context) DeclRefExpr(var, false, type, VK_LValue, poi); - ExprResult result = - PerformCopyInitialization( - InitializedEntity::InitializeBlock(poi, type, false), - poi, Owned(varRef)); + ExprResult result + = PerformMoveOrCopyInitialization( + InitializedEntity::InitializeBlock(poi, type, false), + var, var->getType(), varRef, /*AllowNRVO=*/true); if (!result.isInvalid()) { result = MaybeCreateExprWithCleanups(result); Expr *init = result.takeAs(); diff --git a/test/SemaCXX/blocks.cpp b/test/SemaCXX/blocks.cpp index 3f81c274d0..a635e998d9 100644 --- a/test/SemaCXX/blocks.cpp +++ b/test/SemaCXX/blocks.cpp @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -fsyntax-only -verify %s -fblocks +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s -fblocks // expected-no-diagnostics void tovoid(void*); @@ -69,3 +69,16 @@ namespace radar8382559 { return hasProperty = 1; } } + +// Move __block variables to the heap when possible. +class MoveOnly { +public: + MoveOnly(); + MoveOnly(const MoveOnly&) = delete; + MoveOnly(MoveOnly&&); +}; + +void move_block() { + __block MoveOnly mo; +} + -- 2.40.0