From 6c74a1766c706eda78554a6c3182601364babd40 Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Tue, 31 Aug 2021 19:53:57 -0700 Subject: [PATCH] remove `make check` Python targets The current Graphviz test suite is orchestrated via Pytest and assumes it is dealing with an installed Graphviz (e.g. headers and libraries available in expected locations). The legacy Autotools check targets gave the incorrect impression that this was the current test suite and it was expected to pass. It has not been possible to run these legacy test scripts for a long time. This commit removes the legacy testing pieces to avoid future confusion. In future it may be useful to plumb the current Pytest test suite to the Autotools post-install test targets (`make installcheck`). Closes #2112. --- CHANGELOG.md | 1 + rtest/Makefile.am | 3 --- tests/regression_tests/installation/Makefile.am | 3 --- tests/regression_tests/shapes/Makefile.am | 3 --- tests/regression_tests/vuln/Makefile.am | 3 --- 5 files changed, 1 insertion(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d35d6f7c8..781cc0a95 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed - various problems in the generation of Javascript bindings +- 2.48.0: test suite is failing #2112 ## [2.49.0] – 2021-08-28 diff --git a/rtest/Makefile.am b/rtest/Makefile.am index d54bfa1a4..9d52aa840 100644 --- a/rtest/Makefile.am +++ b/rtest/Makefile.am @@ -1,6 +1,3 @@ SUBDIRS = graphs linux.x86 -check test rtest: $(top_builddir)/cmd/dot/dot_builtins $(top_builddir)/contrib/diffimg/diffimg - DOT=$(top_builddir)/cmd/dot/dot_builtins DIFFIMG=$(top_builddir)/contrib/diffimg/diffimg $(top_srcdir)/rtest/rtest.py - EXTRA_DIST = graphs nshare rtest.py strps.awk tests.txt tests_subset.txt test_regression.py diff --git a/tests/regression_tests/installation/Makefile.am b/tests/regression_tests/installation/Makefile.am index 55b238068..438b2206c 100644 --- a/tests/regression_tests/installation/Makefile.am +++ b/tests/regression_tests/installation/Makefile.am @@ -1,5 +1,2 @@ -check test rtest: - python3 -m pytest - EXTRA_DIST = \ test_installation.py diff --git a/tests/regression_tests/shapes/Makefile.am b/tests/regression_tests/shapes/Makefile.am index 8ac3d18b0..898b2e1af 100644 --- a/tests/regression_tests/shapes/Makefile.am +++ b/tests/regression_tests/shapes/Makefile.am @@ -1,8 +1,5 @@ SUBDIRS = reference -check test rtest: - python3 shapes.py - EXTRA_DIST = \ test_shapes.py \ shapes.py diff --git a/tests/regression_tests/vuln/Makefile.am b/tests/regression_tests/vuln/Makefile.am index ae3cbbb38..83d460335 100644 --- a/tests/regression_tests/vuln/Makefile.am +++ b/tests/regression_tests/vuln/Makefile.am @@ -1,6 +1,3 @@ SUBDIRS = input reference -check test rtest: - python vuln.py - EXTRA_DIST = vuln.py -- 2.40.0