From 6c08905d4c07d2215c2fb09aca6b877bb161c915 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Fri, 27 Dec 2002 17:10:45 +0000 Subject: [PATCH] Remove overenthusiastic free'ing of comment dependencies; could lead to core dump in pg_dump when dumping views having comments. See bug #855. --- src/bin/pg_dump/pg_dump.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c index e5570fa6d1..6c611f22bf 100644 --- a/src/bin/pg_dump/pg_dump.c +++ b/src/bin/pg_dump/pg_dump.c @@ -12,7 +12,7 @@ * by PostgreSQL * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.312 2002/12/21 22:45:09 tgl Exp $ + * $Header: /cvsroot/pgsql/src/bin/pg_dump/pg_dump.c,v 1.313 2002/12/27 17:10:45 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -5496,12 +5496,7 @@ dumpOneTable(Archive *fout, TableInfo *tbinfo, TableInfo *g_tblinfo) /* Dump Table Comments */ dumpTableComment(fout, tbinfo, reltypename, commentDeps); - if (commentDeps) - { - for (j = 0; (*commentDeps)[j] != NULL; j++) - free((void *) (*commentDeps)[j]); - free(commentDeps); - } + /* commentDeps now belongs to the archive entry ... don't free it! */ destroyPQExpBuffer(query); destroyPQExpBuffer(q); -- 2.40.0