From 6aae87d3839fad00b46159b5b67ef1da5f6c19e9 Mon Sep 17 00:00:00 2001 From: Fariborz Jahanian Date: Fri, 2 Apr 2010 20:09:24 +0000 Subject: [PATCH] Diagnose invalid code with -fobjc-nonfragile-abi2 when property is being accessed without the dot-syntax notation. (radar 7822344). git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@100212 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaExpr.cpp | 5 ----- test/SemaObjC/default-synthesize.m | 16 ++++++++-------- 2 files changed, 8 insertions(+), 13 deletions(-) diff --git a/lib/Sema/SemaExpr.cpp b/lib/Sema/SemaExpr.cpp index fbdf080bc4..2dfb95435d 100644 --- a/lib/Sema/SemaExpr.cpp +++ b/lib/Sema/SemaExpr.cpp @@ -1345,11 +1345,6 @@ Sema::LookupInObjCMethod(LookupResult &Lookup, Scope *S, } } } - if (LangOpts.ObjCNonFragileABI2 && LookForIvars && Lookup.empty()) { - ObjCIvarDecl *Ivar = SynthesizeNewPropertyIvar(IFace, II); - if (Ivar) - return LookupInObjCMethod(Lookup, S, II, AllowBuiltinCreation); - } // Sentinel value saying that we didn't do anything special. return Owned((Expr*) 0); } diff --git a/test/SemaObjC/default-synthesize.m b/test/SemaObjC/default-synthesize.m index be2397bd20..45a3710dcf 100644 --- a/test/SemaObjC/default-synthesize.m +++ b/test/SemaObjC/default-synthesize.m @@ -23,12 +23,12 @@ //@synthesize howMany, what; - (int) howMany { - return howMany; + return self.howMany; } // - (void) setHowMany: (int) value - (NSString*) what { - return what; + return self.what; } // - (void) setWhat: (NSString*) value @end @@ -44,12 +44,12 @@ // - (int) howMany - (void) setHowMany: (int) value { - howMany = value; + self.howMany = value; } // - (NSString*) what - (void) setWhat: (NSString*) value { - if (what != value) { + if (self.what != value) { } } @end @@ -64,17 +64,17 @@ //@synthesize howMany, what; // REM: Redundant anyway - (int) howMany { - return howMany; + return self.howMany; } - (void) setHowMany: (int) value { - howMany = value; + self.howMany = value; } - (NSString*) what { - return what; + return self.what; } - (void) setWhat: (NSString*) value { - if (what != value) { + if (self.what != value) { } } @end -- 2.50.1