From 6a7ec065ddc8155f6d1f165b626c76b382d918ae Mon Sep 17 00:00:00 2001 From: Matthew Fernandez Date: Fri, 13 May 2022 08:04:07 -0700 Subject: [PATCH] mingle: remove unused 'total_wgt' in 'agglomerative_ink_bundling_internal' MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The CMake macOS CI job has begun erroring out: …/lib/mingle/agglomerative_bundling.cpp:400:27: error: variable 'total_wgt' set but not used [-Werror,-Wunused-but-set-variable] double eps = 0., wgt, total_wgt = 0; ^ While the error is accurate, nothing has changed on our side that would have caused this. I can only assume Gitlab have upgraded the macOS runners to pull in a new version of Clang. --- lib/mingle/agglomerative_bundling.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/mingle/agglomerative_bundling.cpp b/lib/mingle/agglomerative_bundling.cpp index 0d285dfaa..213bb118a 100644 --- a/lib/mingle/agglomerative_bundling.cpp +++ b/lib/mingle/agglomerative_bundling.cpp @@ -397,7 +397,7 @@ static pedge* agglomerative_ink_bundling_internal(int dim, SparseMatrix A, pedge pedge *mid_edges, midedge;/* middle section of edges that will be bundled again */ int ne, npp, l; SparseMatrix A_mid; - double eps = 0., wgt, total_wgt = 0; + double eps = 0., wgt; /* make new edges using meet1 and meet2. @@ -417,7 +417,6 @@ static pedge* agglomerative_ink_bundling_internal(int dim, SparseMatrix A, pedge pick = &(ja[ia[i]]); wgt = 0.; for (j = ia[i]; j < ia[i+1]; j++) wgt += edges[j]->wgt; - total_wgt += wgt; if (DEBUG) if (Verbose) fprintf(stderr,"calling ink3...\n"); ink1 = ink(edges, ia[i+1]-ia[i], pick, &ink0, &meet1, &meet2, angle_param, angle); if (DEBUG) if (Verbose) fprintf(stderr,"done calling ink3...\n"); -- 2.40.0