From 6a4ffd7295e4c6a1da4f0ef4e381ebfbc1bff398 Mon Sep 17 00:00:00 2001 From: Brian Curtin Date: Tue, 5 Jul 2011 19:14:16 -0500 Subject: [PATCH] Fix #11512. Add an initial test suite for the cgitb, providing 75% coverage. Patch by Robbie Clemons (robquad), produced at the PyCon 2011 sprints. --- Lib/test/test_cgitb.py | 55 ++++++++++++++++++++++++++++++++++++++++++ Misc/ACKS | 1 + Misc/NEWS | 2 ++ 3 files changed, 58 insertions(+) create mode 100644 Lib/test/test_cgitb.py diff --git a/Lib/test/test_cgitb.py b/Lib/test/test_cgitb.py new file mode 100644 index 0000000000..f7e851a48f --- /dev/null +++ b/Lib/test/test_cgitb.py @@ -0,0 +1,55 @@ +from test.support import run_unittest +import unittest +import sys +import subprocess +import cgitb + +class TestCgitb(unittest.TestCase): + + def test_fonts(self): + text = "Hello Robbie!" + self.assertEqual(cgitb.small(text), "{}".format(text)) + self.assertEqual(cgitb.strong(text), "{}".format(text)) + self.assertEqual(cgitb.grey(text), + '{}'.format(text)) + + def test_blanks(self): + self.assertEqual(cgitb.small(""), "") + self.assertEqual(cgitb.strong(""), "") + self.assertEqual(cgitb.grey(""), "") + + def test_html(self): + try: + raise ValueError("Hello World") + except ValueError as err: + # If the html was templated we could do a bit more here. + # At least check that we get details on what we just raised. + html = cgitb.html(sys.exc_info()) + self.assertIn("ValueError", html) + self.assertIn(str(err), html) + + def test_text(self): + try: + raise ValueError("Hello World") + except ValueError as err: + text = cgitb.text(sys.exc_info()) + self.assertIn("ValueError", text) + self.assertIn("Hello World", text) + + def test_hook(self): + proc = subprocess.Popen([sys.executable, '-c', + ('import cgitb;' + 'cgitb.enable();' + 'raise ValueError("Hello World")')], + stdout=subprocess.PIPE) + out = proc.stdout.read().decode(sys.getfilesystemencoding()) + self.addCleanup(proc.stdout.close) + self.assertIn("ValueError", out) + self.assertIn("Hello World", out) + + +def test_main(): + run_unittest(TestCgitb) + +if __name__ == "__main__": + test_main() diff --git a/Misc/ACKS b/Misc/ACKS index 3fb0d9d321..378b60eca7 100644 --- a/Misc/ACKS +++ b/Misc/ACKS @@ -175,6 +175,7 @@ David Cinege Mike Clarkson Andrew Clegg Brad Clements +Robbie Clemons Steve Clift Nick Coghlan Josh Cogliati diff --git a/Misc/NEWS b/Misc/NEWS index b96ca50df0..f742f8afa2 100644 --- a/Misc/NEWS +++ b/Misc/NEWS @@ -994,6 +994,8 @@ Extension Modules Tests ----- +- Issue #11512: Add a test suite for the cgitb module. Patch by Robbie Clemons. + - Issue #12497: Install test/data to prevent failures of the various codecmaps tests. -- 2.50.0