From 6992c20df0d28e3ed8c47d1b1320de60880f099b Mon Sep 17 00:00:00 2001 From: Ivan Maidanski Date: Wed, 11 Jul 2018 00:41:33 +0300 Subject: [PATCH] Eliminate 'ptr arithmetic with NULL' cppcheck warning in alloc_mark_stack * mark.c (alloc_mark_stack): Wrap GC_mark_stack_limit (and GC_mark_stack, GC_mark_stack_size) assignment into "else" block (after EXIT). --- mark.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/mark.c b/mark.c index 3ca2841f..bf28a8ad 100644 --- a/mark.c +++ b/mark.c @@ -1298,11 +1298,10 @@ static void alloc_mark_stack(size_t n) } else { WARN("Failed to grow mark stack to %" WARN_PRIdPTR " frames\n", n); } + } else if (NULL == new_stack) { + GC_err_printf("No space for mark stack\n"); + EXIT(); } else { - if (new_stack == 0) { - GC_err_printf("No space for mark stack\n"); - EXIT(); - } GC_mark_stack = new_stack; GC_mark_stack_size = n; GC_mark_stack_limit = new_stack + n; -- 2.50.1