From 688791b22b52ba9b127a0e7d19d846fa9830160e Mon Sep 17 00:00:00 2001 From: Geoff Thorpe Date: Wed, 21 Apr 2004 15:09:25 +0000 Subject: [PATCH] Extend the index parameter checking from sk_value to sk_set(). Also tidy up some similar code elsewhere. Thanks to Francesco Petruzzi for bringing this to my attention. --- crypto/stack/stack.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/crypto/stack/stack.c b/crypto/stack/stack.c index ff6d14a86c..a6ecbe4c68 100644 --- a/crypto/stack/stack.c +++ b/crypto/stack/stack.c @@ -191,8 +191,7 @@ char *sk_delete(STACK *st, int loc) char *ret; int i,j; - if ((st == NULL) || (st->num == 0) || (loc < 0) - || (loc >= st->num)) return(NULL); + if(!st || (loc < 0) || (loc >= st->num)) return NULL; ret=st->data[loc]; if (loc != st->num-1) @@ -312,7 +311,7 @@ char *sk_value(const STACK *st, int i) char *sk_set(STACK *st, int i, char *value) { - if(st == NULL) return NULL; + if(!st || (i < 0) || (i >= st->num)) return NULL; return (st->data[i] = value); } -- 2.50.1