From 6786d53d4585b3b2cbe78b39bef54e133f352f1d Mon Sep 17 00:00:00 2001 From: "Todd C. Miller" Date: Fri, 19 Oct 2018 13:32:24 -0600 Subject: [PATCH] In timestamp_open() no need to free cookie on error, it is NULL. Found by PVS-Studio. --- plugins/sudoers/timestamp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/plugins/sudoers/timestamp.c b/plugins/sudoers/timestamp.c index 7a854a35a..511029d82 100644 --- a/plugins/sudoers/timestamp.c +++ b/plugins/sudoers/timestamp.c @@ -412,7 +412,7 @@ ts_init_key_nonglobal(struct timestamp_entry *entry, struct passwd *pw, int flag void * timestamp_open(const char *user, pid_t sid) { - struct ts_cookie *cookie = NULL; + struct ts_cookie *cookie; char *fname = NULL; int tries, fd = -1; debug_decl(timestamp_open, SUDOERS_DEBUG_AUTH) @@ -485,7 +485,6 @@ timestamp_open(const char *user, pid_t sid) bad: if (fd != -1) close(fd); - free(cookie); free(fname); debug_return_ptr(NULL); } -- 2.50.1