From 6776d26fdcfd53479bb479e0211303337cd5c324 Mon Sep 17 00:00:00 2001 From: Kalle Sommer Nielsen Date: Fri, 23 Jan 2009 15:48:58 +0000 Subject: [PATCH] Windows support for stream_socket_pair(), by moving the socketpair() implementation from ext/sockets to win32/ --- ext/sockets/config.w32 | 2 +- ext/sockets/php_sockets.h | 9 +++++- ext/sockets/sockets.c | 17 ++++++++--- ext/standard/streamsfuncs.c | 1 + ext/standard/streamsfuncs.h | 5 +++- .../tests/streams/stream_socket_pair.phpt | 7 ++--- win32/build/config.w32 | 2 +- win32/build/config.w32.h.in | 3 ++ .../php_sockets_win.c => win32/sockets.c | 28 ++++++++----------- .../php_sockets_win.h => win32/sockets.h | 25 ++--------------- 10 files changed, 47 insertions(+), 52 deletions(-) rename ext/sockets/php_sockets_win.c => win32/sockets.c (85%) rename ext/sockets/php_sockets_win.h => win32/sockets.h (75%) diff --git a/ext/sockets/config.w32 b/ext/sockets/config.w32 index 587b9a1b12..c0c6fc1c90 100644 --- a/ext/sockets/config.w32 +++ b/ext/sockets/config.w32 @@ -6,7 +6,7 @@ ARG_ENABLE("sockets", "SOCKETS support", "no"); if (PHP_SOCKETS != "no") { if (CHECK_LIB("ws2_32.lib", "sockets", PHP_SOCKETS)) { - EXTENSION('sockets', 'sockets.c php_sockets_win.c'); + EXTENSION('sockets', 'sockets.c'); AC_DEFINE('HAVE_SOCKETS', 1); } else { WARNING("sockets not enabled; libraries and headers not found"); diff --git a/ext/sockets/php_sockets.h b/ext/sockets/php_sockets.h index f0c9cc5203..3db96dc2ab 100644 --- a/ext/sockets/php_sockets.h +++ b/ext/sockets/php_sockets.h @@ -43,7 +43,7 @@ PHP_RSHUTDOWN_FUNCTION(sockets); PHP_FUNCTION(socket_select); PHP_FUNCTION(socket_create_listen); -#if defined(HAVE_SOCKETPAIR) || defined(PHP_WIN32) +#ifdef HAVE_SOCKETPAIR PHP_FUNCTION(socket_create_pair); #endif PHP_FUNCTION(socket_accept); @@ -84,6 +84,13 @@ typedef struct { int blocking; } php_socket; +#ifdef PHP_WIN32 +struct sockaddr_un { + short sun_family; + char sun_path[108]; +}; +#endif + /* Prototypes */ #ifdef ilia_0 /* not needed, only causes a compiler warning */ static int php_open_listen_sock(php_socket **php_sock, int port, int backlog TSRMLS_DC); diff --git a/ext/sockets/sockets.c b/ext/sockets/sockets.c index 62a2039eea..d027d3bcec 100644 --- a/ext/sockets/sockets.c +++ b/ext/sockets/sockets.c @@ -39,8 +39,17 @@ # include # include # include "php_sockets.h" -# include "php_sockets_win.h" +# include "win32/sockets.h" # define IS_INVALID_SOCKET(a) (a->bsd_socket == INVALID_SOCKET) +# define EPROTONOSUPPORT WSAEPROTONOSUPPORT +# define ECONNRESET WSAECONNRESET +# ifdef errno +# undef errno +# endif +# define errno WSAGetLastError() +# define h_errno WSAGetLastError() +# define set_errno(a) WSASetLastError(a) +# define close(a) closesocket(a) #else # include "php_sockets.h" # include @@ -223,7 +232,7 @@ ZEND_BEGIN_ARG_INFO_EX(arginfo_socket_set_option, 0, 0, 4) ZEND_ARG_INFO(0, optval) ZEND_END_ARG_INFO() -#if defined(HAVE_SOCKETPAIR) || defined(PHP_WIN32) +#ifdef HAVE_SOCKETPAIR ZEND_BEGIN_ARG_INFO_EX(arginfo_socket_create_pair, 0, 0, 4) ZEND_ARG_INFO(0, domain) ZEND_ARG_INFO(0, type) @@ -254,7 +263,7 @@ const zend_function_entry sockets_functions[] = { PHP_FE(socket_select, arginfo_socket_select) PHP_FE(socket_create, arginfo_socket_create) PHP_FE(socket_create_listen, arginfo_socket_create_listen) -#if defined(HAVE_SOCKETPAIR) || defined(PHP_WIN32) +#ifdef HAVE_SOCKETPAIR PHP_FE(socket_create_pair, arginfo_socket_create_pair) #endif PHP_FE(socket_accept, arginfo_socket_accept) @@ -1857,7 +1866,7 @@ PHP_FUNCTION(socket_set_option) } /* }}} */ -#if defined(HAVE_SOCKETPAIR) || defined(PHP_WIN32) +#ifdef HAVE_SOCKETPAIR /* {{{ proto bool socket_create_pair(int domain, int type, int protocol, array &fd) U Creates a pair of indistinguishable sockets and stores them in fds. */ PHP_FUNCTION(socket_create_pair) diff --git a/ext/standard/streamsfuncs.c b/ext/standard/streamsfuncs.c index 80b4967427..0ef4a695c1 100644 --- a/ext/standard/streamsfuncs.c +++ b/ext/standard/streamsfuncs.c @@ -36,6 +36,7 @@ typedef unsigned long long php_timeout_ull; #else #include "win32/select.h" +#include "win32/sockets.h" typedef unsigned __int64 php_timeout_ull; #endif diff --git a/ext/standard/streamsfuncs.h b/ext/standard/streamsfuncs.h index aaa20c334c..bb1ae03477 100644 --- a/ext/standard/streamsfuncs.h +++ b/ext/standard/streamsfuncs.h @@ -57,11 +57,14 @@ PHP_FUNCTION(stream_filter_remove); PHP_FUNCTION(stream_encoding); PHP_FUNCTION(stream_socket_enable_crypto); PHP_FUNCTION(stream_socket_shutdown); -PHP_FUNCTION(stream_socket_pair); PHP_FUNCTION(stream_resolve_include_path); PHP_FUNCTION(stream_is_local); PHP_FUNCTION(stream_supports_lock); +#if HAVE_SOCKETPAIR +PHP_FUNCTION(stream_socket_pair); +#endif + /* * Local variables: * tab-width: 4 diff --git a/ext/standard/tests/streams/stream_socket_pair.phpt b/ext/standard/tests/streams/stream_socket_pair.phpt index 5556d8e22c..4560228564 100644 --- a/ext/standard/tests/streams/stream_socket_pair.phpt +++ b/ext/standard/tests/streams/stream_socket_pair.phpt @@ -1,12 +1,9 @@ --TEST-- stream_socket_pair() ---SKIPIF-- - --FILE-- #include #include "php.h" -#include "php_sockets.h" -#include "php_sockets_win.h" -int socketpair(int domain, int type, int protocol, SOCKET sock[2]) { +PHPAPI int socketpair(int domain, int type, int protocol, SOCKET sock[2]) +{ struct sockaddr_in address; SOCKET redirect; int size = sizeof(address); if(domain != AF_INET) { - set_errno(WSAENOPROTOOPT); + WSASetLastError(WSAENOPROTOOPT); return -1; } - sock[0] = socket(domain, type, protocol); - address.sin_addr.s_addr = INADDR_ANY; + sock[0] = socket(domain, type, protocol); + address.sin_addr.s_addr = INADDR_ANY; address.sin_family = AF_INET; address.sin_port = 0; bind(sock[0], (struct sockaddr*)&address, sizeof(address)); - if(getsockname(sock[0], (struct sockaddr *)&address, &size) != 0) { - } + if(getsockname(sock[0], (struct sockaddr *)&address, &size) != 0) { + } listen(sock[0], 2); sock[1] = socket(domain, type, protocol); @@ -59,17 +57,15 @@ int socketpair(int domain, int type, int protocol, SOCKET sock[2]) { connect(sock[1], (struct sockaddr*)&address, sizeof(address)); redirect = accept(sock[0],(struct sockaddr*)&address, &size); - close(sock[0]); + closesocket(sock[0]); sock[0] = redirect; if(sock[0] == INVALID_SOCKET ) { - close(sock[0]); - close(sock[1]); - set_errno(WSAECONNABORTED); + closesocket(sock[0]); + closesocket(sock[1]); + WSASetLastError(WSAECONNABORTED); return -1; } return 0; } - -#endif diff --git a/ext/sockets/php_sockets_win.h b/win32/sockets.h similarity index 75% rename from ext/sockets/php_sockets_win.h rename to win32/sockets.h index f7e7c55e78..0d8bb07c8a 100644 --- a/ext/sockets/php_sockets_win.h +++ b/win32/sockets.h @@ -21,27 +21,6 @@ /* $Id$ */ +/* Code originally from ext/sockets */ -#ifdef PHP_WIN32 - -#define EPROTONOSUPPORT WSAEPROTONOSUPPORT -#define ECONNRESET WSAECONNRESET - -#ifdef errno -#undef errno -#endif - -#define errno WSAGetLastError() -#define h_errno WSAGetLastError() -#define set_errno(a) WSASetLastError(a) -#define close(a) closesocket(a) - -struct sockaddr_un { - short sun_family; - char sun_path[108]; -}; - -int socketpair(int domain, int type, int protocol, SOCKET sock[2]); -int inet_aton(const char *cp, struct in_addr *inp); - -#endif +PHPAPI int socketpair(int domain, int type, int protocol, SOCKET sock[2]); \ No newline at end of file -- 2.50.1