From 65732af7da2a32bf43c1a0918a6725c4c333182d Mon Sep 17 00:00:00 2001 From: Ilia Alshanetsky Date: Mon, 17 Oct 2011 23:51:25 +0000 Subject: [PATCH] Fixed bug #55543 (json_encode() with JSON_NUMERIC_CHECK fails on objects with numeric string properties) --- ext/json/json.c | 2 +- ext/json/tests/bug55543.phpt | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 ext/json/tests/bug55543.phpt diff --git a/ext/json/json.c b/ext/json/json.c index 3c20498aa8..c7759ed740 100644 --- a/ext/json/json.c +++ b/ext/json/json.c @@ -297,7 +297,7 @@ static void json_encode_array(smart_str *buf, zval **val, int options TSRMLS_DC) json_pretty_print_indent(buf, options TSRMLS_CC); - json_escape_string(buf, key, key_len - 1, options TSRMLS_CC); + json_escape_string(buf, key, key_len - 1, options & ~PHP_JSON_NUMERIC_CHECK TSRMLS_CC); smart_str_appendc(buf, ':'); json_pretty_print_char(buf, options, ' ' TSRMLS_CC); diff --git a/ext/json/tests/bug55543.phpt b/ext/json/tests/bug55543.phpt new file mode 100644 index 0000000000..8657fe7767 --- /dev/null +++ b/ext/json/tests/bug55543.phpt @@ -0,0 +1,13 @@ +--TEST-- +Bug #55543 (json_encode() with JSON_NUMERIC_CHECK & numeric string properties) +--SKIPIF-- + +--FILE-- +{"1"} = "5"; + +var_dump(json_encode($a, JSON_NUMERIC_CHECK)); +?> +--EXPECT-- +string(7) "{"1":5}" -- 2.50.1