From 651ac560976303c22335dfe07cbb1c34048e811a Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Tue, 11 Apr 2017 22:29:19 +0000 Subject: [PATCH] AMDGPU: Fix folding reg_sequence into copy to phys reg This was producing an illegal reg_sequence defining a physical register with virtual register inputs. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@299997 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/AMDGPU/SIFixSGPRCopies.cpp | 4 ++++ test/CodeGen/AMDGPU/inline-asm.ll | 13 +++++++++++++ 2 files changed, 17 insertions(+) diff --git a/lib/Target/AMDGPU/SIFixSGPRCopies.cpp b/lib/Target/AMDGPU/SIFixSGPRCopies.cpp index 43cb15f502c..34cd6f704a1 100644 --- a/lib/Target/AMDGPU/SIFixSGPRCopies.cpp +++ b/lib/Target/AMDGPU/SIFixSGPRCopies.cpp @@ -198,6 +198,10 @@ static bool foldVGPRCopyIntoRegSequence(MachineInstr &MI, if (!CopyUse.isCopy()) return false; + // It is illegal to have vreg inputs to a physreg defining reg_sequence. + if (TargetRegisterInfo::isPhysicalRegister(CopyUse.getOperand(0).getReg())) + return false; + const TargetRegisterClass *SrcRC, *DstRC; std::tie(SrcRC, DstRC) = getCopyRegClasses(CopyUse, *TRI, MRI); diff --git a/test/CodeGen/AMDGPU/inline-asm.ll b/test/CodeGen/AMDGPU/inline-asm.ll index 85eb163383e..5d49b11f0d4 100644 --- a/test/CodeGen/AMDGPU/inline-asm.ll +++ b/test/CodeGen/AMDGPU/inline-asm.ll @@ -183,3 +183,16 @@ entry: ", ""() ret void } + +; FIXME: Should not have intermediate sgprs +; CHECK-LABEL: {{^}}i64_imm_input_phys_vgpr: +; CHECK: s_mov_b32 s1, 0 +; CHECK: s_mov_b32 s0, 0x1e240 +; CHECK: v_mov_b32_e32 v0, s0 +; CHECK: v_mov_b32_e32 v1, s1 +; CHECK: use v[0:1] +define void @i64_imm_input_phys_vgpr() { +entry: + call void asm sideeffect "; use $0 ", "{VGPR0_VGPR1}"(i64 123456) + ret void +} -- 2.50.1