From 64b6eceaba1a40ab0b175fa9fd9329d3e978ce6e Mon Sep 17 00:00:00 2001 From: Azat Khuzhin Date: Thu, 28 Feb 2013 17:19:44 +0400 Subject: [PATCH] uri decode: fix for warning "use of uninitialised value" This patch add check in evhttp_decode_uri_internal() that next 2 symbols are exists in array of chars for decoding, if don't have two next 2 symbols don't try to decode '%FF' --- http.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/http.c b/http.c index b94fed8c..ff331e6c 100644 --- a/http.c +++ b/http.c @@ -2889,8 +2889,8 @@ evhttp_decode_uri_internal( decode_plus = 1; } else if (c == '+' && decode_plus) { c = ' '; - } else if (c == '%' && EVUTIL_ISXDIGIT_(uri[i+1]) && - EVUTIL_ISXDIGIT_(uri[i+2])) { + } else if (length > 2 && i < (length - 2) && c == '%' && + EVUTIL_ISXDIGIT_(uri[i+1]) && EVUTIL_ISXDIGIT_(uri[i+2])) { char tmp[3]; tmp[0] = uri[i+1]; tmp[1] = uri[i+2]; -- 2.40.0