From 648e7630008aac5caa591bcc6d0f77b9594b85fd Mon Sep 17 00:00:00 2001 From: Richard Trieu Date: Fri, 29 Jun 2012 23:11:10 +0000 Subject: [PATCH] Fix typos from r159463 and update tests. Added Matt Beaumont-Gay's suggestion to improve wording of a diagnostic message. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@159473 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/clang/Basic/DiagnosticSemaKinds.td | 7 +- test/Misc/diag-template-diffing-color.cpp | 4 +- test/Misc/diag-template-diffing.cpp | 76 +++++++++++----------- 3 files changed, 44 insertions(+), 43 deletions(-) diff --git a/include/clang/Basic/DiagnosticSemaKinds.td b/include/clang/Basic/DiagnosticSemaKinds.td index 4ebceed5bf..1872ec5033 100644 --- a/include/clang/Basic/DiagnosticSemaKinds.td +++ b/include/clang/Basic/DiagnosticSemaKinds.td @@ -1159,12 +1159,12 @@ def err_lvalue_reference_bind_to_temporary : Error< "%select{non-const|volatile}0 lvalue reference %diff{to type $ cannot bind " "to a temporary of type $|cannot bind to incompatible temporary}1,2">; def err_lvalue_reference_bind_to_unrelated : Error< - "%select{non-const|volatile}0 lvalue reference %diff{to type $ cannot bind to a value of unrelated type $|cannot bind to a value of related type}1,2">; + "%select{non-const|volatile}0 lvalue reference %diff{to type $ cannot bind to a value of unrelated type $|cannot bind to a value of unrelated type}1,2">; def err_reference_bind_drops_quals : Error< "binding of reference %diff{to type $ to a value of type $ drops " "qualifiers|drops qualifiers}0,1">; def err_reference_bind_failed : Error< - "reference %diff{to type $ could not bind to an %select{rvalue|lvalue}1 of type $|could not bing to %select{rvalue|lvalue}}0,2">; + "reference %diff{to type $ could not bind to an %select{rvalue|lvalue}1 of type $|could not bind to %select{rvalue|lvalue}}0,2">; def err_reference_bind_init_list : Error< "reference to type %0 cannot bind to an initializer list">; def warn_temporary_array_to_pointer_decay : Warning< @@ -2168,7 +2168,8 @@ def note_ovl_candidate_bad_conv : Note<"candidate " "function (the implicit copy assignment operator)|" "function (the implicit move assignment operator)|" "constructor (inherited)}0%1" - " not viable: no known conversion %diff{from $ to $ |}2,3for " + " not viable: no known conversion " + "%diff{from $ to $|from argument type to parameter type}2,3 for " "%select{%ordinal5 argument|object argument}4" "%select{|; dereference the argument with *|" "; take the address of the argument with &|" diff --git a/test/Misc/diag-template-diffing-color.cpp b/test/Misc/diag-template-diffing-color.cpp index b944ef2bb0..fc100e30dd 100644 --- a/test/Misc/diag-template-diffing-color.cpp +++ b/test/Misc/diag-template-diffing-color.cpp @@ -7,13 +7,13 @@ int main() { func(foo()); } // CHECK: {{.*}}candidate function not viable: no known conversion from 'foo<{{.}}[0;1;36mdouble{{.}}[0m>' to 'foo<{{.}}[0;1;36mint{{.}}[0m>' for 1st argument{{.}}[0m -// TREE: candidate function not viable: no known conversion for 1st argument +// TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // TREE: foo< // TREE: [{{.}}[0;1;36mdouble{{.}}[0m != {{.}}[0;1;36mint{{.}}[0m]>{{.}}[0m foo A; foo &B = A; // CHECK: {{.*}}non-const lvalue reference to type 'foo<{{.}}[0;1;36mdouble{{.}}[0m{{.}}[1m>' cannot bind to a value of unrelated type 'foo<{{.}}[0;1;36mint{{.}}[0m{{.}}[1m>'{{.}}[0m -// TREE: non-const lvalue reference cannot bind to a value of related type +// TREE: non-const lvalue reference cannot bind to a value of unrelated type // TREE: foo< // TREE: [{{.}}[0;1;36mdouble{{.}}[0m{{.}}[1m != {{.}}[0;1;36mint{{.}}[0m{{.}}[1m]>{{.}}[0m diff --git a/test/Misc/diag-template-diffing.cpp b/test/Misc/diag-template-diffing.cpp index 0e7a678ad7..9addcc50ae 100644 --- a/test/Misc/diag-template-diffing.cpp +++ b/test/Misc/diag-template-diffing.cpp @@ -28,11 +28,11 @@ namespace std { // CHECK-NOELIDE-NOTREE: no matching function for call to 'f' // CHECK-NOELIDE-NOTREE: candidate function not viable: no known conversion from 'vector' to 'vector' for 1st argument // CHECK-ELIDE-TREE: no matching function for call to 'f' -// CHECK-ELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-ELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-ELIDE-TREE: vector< // CHECK-ELIDE-TREE: [class std::basic_string != class versa_string]> // CHECK-NOELIDE-TREE: no matching function for call to 'f' -// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-NOELIDE-TREE: vector< // CHECK-NOELIDE-TREE: [class std::basic_string != class versa_string]> @@ -47,14 +47,14 @@ void test1() { // CHECK-NOELIDE-NOTREE: no matching function for call to 'set1' // CHECK-NOELIDE-NOTREE: candidate function not viable: no known conversion from 'I1<1, 2, 3, 4, 2, 2, 4, 3, 7>' to 'I1<1, 2, 3, 4, 2, 3, 4, 3, (no argument)>' for 1st argument // CHECK-ELIDE-TREE: no matching function for call to 'set1' -// CHECK-ELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-ELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-ELIDE-TREE: I1< // CHECK-ELIDE-TREE: [5 * ...], // CHECK-ELIDE-TREE: [2 != 3], // CHECK-ELIDE-TREE: [2 * ...], // CHECK-ELIDE-TREE: [7 != (no argument)]> // CHECK-NOELIDE-TREE: no matching function for call to 'set1' -// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-NOELIDE-TREE: I1< // CHECK-NOELIDE-TREE: 1, // CHECK-NOELIDE-TREE: 2, @@ -77,13 +77,13 @@ void test2() { // CHECK-NOELIDE-NOTREE: no matching function for call to 'set2' // CHECK-NOELIDE-NOTREE: candidate function not viable: no known conversion from 'I2' to 'I2' for 1st argument // CHECK-ELIDE-TREE: no matching function for call to 'set2' -// CHECK-ELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-ELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-ELIDE-TREE: I2< // CHECK-ELIDE-TREE: [double != int], // CHECK-ELIDE-TREE: [...], // CHECK-ELIDE-TREE: [int != (default) void]> // CHECK-NOELIDE-TREE: no matching function for call to 'set2' -// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-NOELIDE-TREE: I2< // CHECK-NOELIDE-TREE: [double != int], // CHECK-NOELIDE-TREE: int, @@ -101,12 +101,12 @@ void test3() { // CHECK-NOELIDE-NOTREE: no matching function for call to 'set3' // CHECK-NOELIDE-NOTREE: candidate function not viable: no known conversion from 'I3<&V3, &V2>' to 'I3<&V1, &V2>' for 1st argument // CHECK-ELIDE-TREE: no matching function for call to 'set3' -// CHECK-ELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-ELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-ELIDE-TREE: I3< // CHECK-ELIDE-TREE: [&V3 != &V1] // CHECK-ELIDE-TREE: [...]> // CHECK-NOELIDE-TREE: no matching function for call to 'set3' -// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-NOELIDE-TREE: I3< // CHECK-NOELIDE-TREE: [&V3 != &V1] // CHECK-NOELIDE-TREE: &V2> @@ -142,7 +142,7 @@ void test5() { // CHECK-NOELIDE-NOTREE: no matching function for call to 'set5' // CHECK-NOELIDE-NOTREE: candidate function not viable: no known conversion from 'Alpha, double>, double>' to 'Alpha, int>, int>, int>' for 1st argument // CHECK-ELIDE-TREE: no matching function for call to 'set5' -// CHECK-ELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-ELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-ELIDE-TREE: Alpha< // CHECK-ELIDE-TREE: Beta< // CHECK-ELIDE-TREE: Gamma< @@ -151,7 +151,7 @@ void test5() { // CHECK-ELIDE-TREE: [double != int]> // CHECK-ELIDE-TREE: [double != int]> // CHECK-NOELIDE-TREE: no matching function for call to 'set5' -// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-NOELIDE-TREE: Alpha< // CHECK-NOELIDE-TREE: Beta< // CHECK-NOELIDE-TREE: Gamma< @@ -168,14 +168,14 @@ void test6() { // CHECK-NOELIDE-NOTREE: no matching function for call to 'set5' // CHECK-NOELIDE-NOTREE: candidate function not viable: no known conversion from 'Alpha, int>, int>' to 'Alpha, int>, int>, int>' for 1st argument // CHECK-ELIDE-TREE: no matching function for call to 'set5' -// CHECK-ELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-ELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-ELIDE-TREE: Alpha< // CHECK-ELIDE-TREE: Beta< // CHECK-ELIDE-TREE: [Delta != Gamma, int>], // CHECK-ELIDE-TREE: [...]> // CHECK-ELIDE-TREE: [...]> // CHECK-NOELIDE-TREE: no matching function for call to 'set5' -// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-NOELIDE-TREE: Alpha< // CHECK-NOELIDE-TREE: Beta< // CHECK-NOELIDE-TREE: [Delta != Gamma, int>], @@ -206,27 +206,27 @@ void test7() { // CHECK-NOELIDE-NOTREE: no matching function for call to 'set7' // CHECK-NOELIDE-NOTREE: candidate function not viable: no known conversion from 'class7' to 'class7<&a7>' for 1st argument // CHECK-ELIDE-TREE: no matching function for call to 'set7' -// CHECK-ELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-ELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-ELIDE-TREE: class7< // CHECK-ELIDE-TREE: [&b7 != &a7]> // CHECK-ELIDE-TREE: no matching function for call to 'set7' -// CHECK-ELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-ELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-ELIDE-TREE: class7< // CHECK-ELIDE-TREE: [c7 != &a7]> // CHECK-ELIDE-TREE: no matching function for call to 'set7' -// CHECK-ELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-ELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-ELIDE-TREE: class7< // CHECK-ELIDE-TREE: [nullptr != &a7]> // CHECK-NOELIDE-TREE: no matching function for call to 'set7' -// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-NOELIDE-TREE: class7< // CHECK-NOELIDE-TREE: [&b7 != &a7]> // CHECK-NOELIDE-TREE: no matching function for call to 'set7' -// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-NOELIDE-TREE: class7< // CHECK-NOELIDE-TREE: [c7 != &a7]> // CHECK-NOELIDE-TREE: no matching function for call to 'set7' -// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-NOELIDE-TREE: class7< // CHECK-NOELIDE-TREE: [nullptr != &a7]> @@ -239,12 +239,12 @@ int k8 = f8(U8()); // CHECK-NOELIDE-NOTREE: no matching function for call to 'f8' // CHECK-NOELIDE-NOTREE: candidate function not viable: no known conversion from 'S8' to 'S8' for 1st argument // CHECK-ELIDE-TREE: no matching function for call to 'f8' -// CHECK-ELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-ELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-ELIDE-TREE: S8< // CHECK-ELIDE-TREE: [2 * ...], // CHECK-ELIDE-TREE: [char != double]> // CHECK-NOELIDE-TREE: no matching function for call to 'f8' -// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-NOELIDE-TREE: S8< // CHECK-NOELIDE-TREE: int, // CHECK-NOELIDE-TREE: char, @@ -261,14 +261,14 @@ int k9 = f9(V9()); // CHECK-NOELIDE-NOTREE: no matching function for call to 'f9' // CHECK-NOELIDE-NOTREE: candidate function not viable: no known conversion from 'S9>' to 'S9>' for 1st argument // CHECK-ELIDE-TREE: no matching function for call to 'f9' -// CHECK-ELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-ELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-ELIDE-TREE: S9< // CHECK-ELIDE-TREE: [2 * ...], // CHECK-ELIDE-TREE: S9< // CHECK-ELIDE-TREE: [2 * ...], // CHECK-ELIDE-TREE: [double != const double]>> // CHECK-NOELIDE-TREE: no matching function for call to 'f9' -// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-NOELIDE-TREE: S9< // CHECK-NOELIDE-TREE: int, // CHECK-NOELIDE-TREE: char, @@ -293,22 +293,22 @@ void test10() { // CHECK-NOELIDE-NOTREE: no matching function for call to 'set10' // CHECK-NOELIDE-NOTREE: candidate function not viable: no known conversion from 'class_types' to 'class_types' for 1st argument // CHECK-ELIDE-TREE: no matching function for call to 'set10' -// CHECK-ELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-ELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-ELIDE-TREE: class_types< // CHECK-ELIDE-TREE: [...], // CHECK-ELIDE-TREE: [(no argument) != int]> // CHECK-ELIDE-TREE: no matching function for call to 'set10' -// CHECK-ELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-ELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-ELIDE-TREE: class_types< // CHECK-ELIDE-TREE: [2 * ...], // CHECK-ELIDE-TREE: [int != (no argument)]> // CHECK-NOELIDE-TREE: no matching function for call to 'set10' -// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-NOELIDE-TREE: class_types< // CHECK-NOELIDE-TREE: int, // CHECK-NOELIDE-TREE: [(no argument) != int]> // CHECK-NOELIDE-TREE: no matching function for call to 'set10' -// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-NOELIDE-TREE: class_types< // CHECK-NOELIDE-TREE: int, // CHECK-NOELIDE-TREE: int, @@ -329,23 +329,23 @@ void test11() { // CHECK-NOELIDE-NOTREE: no matching function for call to 'set11' // CHECK-NOELIDE-NOTREE: candidate function not viable: no known conversion from 'class_ints<0, 3, 6>' to 'class_ints<2, 3, (no argument)>' for 1st argument // CHECK-ELIDE-TREE: no matching function for call to 'set11' -// CHECK-ELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-ELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-ELIDE-TREE: class_ints< // CHECK-ELIDE-TREE: [1 != 2], // CHECK-ELIDE-TREE: [(no argument) != 3]> // CHECK-ELIDE-TREE: no matching function for call to 'set11' -// CHECK-ELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-ELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-ELIDE-TREE: class_ints< // CHECK-ELIDE-TREE: [0 != 2], // CHECK-ELIDE-TREE: [...], // CHECK-ELIDE-TREE: [6 != (no argument)]> // CHECK-NOELIDE-TREE: no matching function for call to 'set11' -// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-NOELIDE-TREE: class_ints< // CHECK-NOELIDE-TREE: [1 != 2], // CHECK-NOELIDE-TREE: [(no argument) != 3]> // CHECK-NOELIDE-TREE: no matching function for call to 'set11' -// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion for 1st argument +// CHECK-NOELIDE-TREE: candidate function not viable: no known conversion from argument type to parameter type for 1st argument // CHECK-NOELIDE-TREE: class_ints< // CHECK-NOELIDE-TREE: [0 != 2], // CHECK-NOELIDE-TREE: 3, @@ -368,22 +368,22 @@ void test12() { // CHECK-NOELIDE-NOTREE: no matching function for call to 'set12' // CHECK-NOELIDE-NOTREE: candidate function not viable: no known conversion from 'class_template_templates