From 63fb6737e7488e3af85c822d4d030663e2b4feaf Mon Sep 17 00:00:00 2001 From: Anders Carlsson Date: Wed, 9 Dec 2009 03:44:46 +0000 Subject: [PATCH] Don't warn about function templates or function template specializations. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@90943 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaDecl.cpp | 18 +++++++++++++----- test/SemaCXX/warn-missing-prototypes.cpp | 13 ++++++++++--- 2 files changed, 23 insertions(+), 8 deletions(-) diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp index 392360f5aa..617adfe363 100644 --- a/lib/Sema/SemaDecl.cpp +++ b/lib/Sema/SemaDecl.cpp @@ -3998,23 +3998,31 @@ static bool ShouldWarnAboutMissingPrototype(const FunctionDecl *FD) { // Don't warn about invalid declarations. if (FD->isInvalidDecl()) return false; - + // Or declarations that aren't global. if (!FD->isGlobal()) return false; - + // Don't warn about C++ member functions. if (isa(FD)) return false; - + // Don't warn about 'main'. if (FD->isMain()) return false; - + // Don't warn about inline functions. if (FD->isInlineSpecified()) return false; - + + // Don't warn about function templates. + if (FD->getDescribedFunctionTemplate()) + return false; + + // Don't warn about function template specializations. + if (FD->isFunctionTemplateSpecialization()) + return false; + bool MissingPrototype = true; for (const FunctionDecl *Prev = FD->getPreviousDeclaration(); Prev; Prev = Prev->getPreviousDeclaration()) { diff --git a/test/SemaCXX/warn-missing-prototypes.cpp b/test/SemaCXX/warn-missing-prototypes.cpp index 481547036e..079a837252 100644 --- a/test/SemaCXX/warn-missing-prototypes.cpp +++ b/test/SemaCXX/warn-missing-prototypes.cpp @@ -7,13 +7,20 @@ namespace NS { } namespace { - // Should not warn about anonymous namespaces + // Don't warn about functions in anonymous namespaces. void f() { } } struct A { - // Should not warn about member functions. + // Don't warn about member functions. void f() { } }; -inline void g() { } \ No newline at end of file +// Don't warn about inline functions. +inline void g() { } + +// Don't warn about function templates. +template void h() { } + +// Don't warn when instantiating function templates. +template void h(); -- 2.40.0