From 638e7cf3a09436dce7f3150ff8e4f27d190bd2ed Mon Sep 17 00:00:00 2001 From: Daniel Dunbar Date: Thu, 27 May 2010 18:42:09 +0000 Subject: [PATCH] Parse/Sema: Add support for '#pragma options align=native'. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@104864 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/clang/Parse/Action.h | 1 + lib/Parse/ParsePragma.cpp | 8 +++++--- lib/Sema/SemaAttr.cpp | 4 ++++ test/Sema/pragma-pack-and-options-align.c | 8 ++++++++ 4 files changed, 18 insertions(+), 3 deletions(-) diff --git a/include/clang/Parse/Action.h b/include/clang/Parse/Action.h index e21da81a8a..d0968599c8 100644 --- a/include/clang/Parse/Action.h +++ b/include/clang/Parse/Action.h @@ -2565,6 +2565,7 @@ public: //===---------------------------- Pragmas -------------------------------===// enum PragmaOptionsAlignKind { + POAK_Native, // #pragma options align=native POAK_Natural, // #pragma options align=natural POAK_Power, // #pragma options align=power POAK_Mac68k, // #pragma options align=mac68k diff --git a/lib/Parse/ParsePragma.cpp b/lib/Parse/ParsePragma.cpp index c4e4a525e5..397d816c76 100644 --- a/lib/Parse/ParsePragma.cpp +++ b/lib/Parse/ParsePragma.cpp @@ -110,7 +110,7 @@ void PragmaPackHandler::HandlePragma(Preprocessor &PP, Token &PackTok) { LParenLoc, RParenLoc); } -// #pragma 'options' 'align' '=' {'natural', 'mac68k', 'power', 'reset'} +// #pragma 'options' 'align' '=' {'native','natural','mac68k','power','reset'} void PragmaOptionsHandler::HandlePragma(Preprocessor &PP, Token &OptionsTok) { SourceLocation OptionsLoc = OptionsTok.getLocation(); @@ -120,7 +120,7 @@ void PragmaOptionsHandler::HandlePragma(Preprocessor &PP, Token &OptionsTok) { PP.Diag(Tok.getLocation(), diag::warn_pragma_options_expected_align); return; } - + PP.Lex(Tok); if (Tok.isNot(tok::equal)) { PP.Diag(Tok.getLocation(), diag::warn_pragma_options_expected_equal); @@ -136,7 +136,9 @@ void PragmaOptionsHandler::HandlePragma(Preprocessor &PP, Token &OptionsTok) { Action::PragmaOptionsAlignKind Kind = Action::POAK_Natural; const IdentifierInfo *II = Tok.getIdentifierInfo(); - if (II->isStr("natural")) + if (II->isStr("native")) + Kind = Action::POAK_Native; + else if (II->isStr("natural")) Kind = Action::POAK_Natural; else if (II->isStr("power")) Kind = Action::POAK_Power; diff --git a/lib/Sema/SemaAttr.cpp b/lib/Sema/SemaAttr.cpp index 82978c9560..c540af2498 100644 --- a/lib/Sema/SemaAttr.cpp +++ b/lib/Sema/SemaAttr.cpp @@ -137,6 +137,10 @@ void Sema::ActOnPragmaOptionsAlign(PragmaOptionsAlignKind Kind, // We don't support #pragma options align=power. switch (Kind) { + // For all targets we support native and natural are the same. + // + // FIXME: This is not true on Darwin/PPC. + case POAK_Native: case POAK_Natural: Context->push(0); Context->setAlignment(0); diff --git a/test/Sema/pragma-pack-and-options-align.c b/test/Sema/pragma-pack-and-options-align.c index c880ed6305..ebf1adee02 100644 --- a/test/Sema/pragma-pack-and-options-align.c +++ b/test/Sema/pragma-pack-and-options-align.c @@ -16,6 +16,14 @@ struct s1 { }; extern int a[sizeof(struct s1) == 8 ? 1 : -1]; +#pragma options align=reset +#pragma options align=native +struct s1_1 { + char c; + int x; +}; +extern int a[sizeof(struct s1_1) == 8 ? 1 : -1]; + #pragma pack(pop) struct s2 { char c; -- 2.49.0