From 638d9f936316bf8e68783e976b0cde7193ebca0e Mon Sep 17 00:00:00 2001
From: nhmall <nhmall@nethack.org>
Date: Sat, 13 Jul 2019 00:17:23 -0400
Subject: [PATCH] if prototype is declared static make function static to match

Today, a compiler was encountered that considered it an error
to have the prototype declared static and the function body
not
---
 src/allmain.c    |  2 +-
 src/apply.c      |  6 +++---
 src/botl.c       |  4 ++--
 src/cmd.c        |  2 +-
 src/display.c    |  2 +-
 src/hack.c       |  4 ++--
 src/isaac64.c    |  2 ++
 src/makemon.c    |  2 +-
 src/mkmaze.c     |  8 ++++----
 src/mon.c        |  4 ++--
 src/objnam.c     |  4 ++--
 src/options.c    |  4 ++--
 src/pager.c      | 22 +++++++++++-----------
 src/pickup.c     |  2 +-
 src/questpgr.c   |  2 +-
 src/shk.c        |  2 +-
 util/makedefs.c  |  4 ++--
 win/tty/wintty.c |  2 +-
 18 files changed, 40 insertions(+), 38 deletions(-)

diff --git a/src/allmain.c b/src/allmain.c
index 1ce8cad08..082447b3b 100644
--- a/src/allmain.c
+++ b/src/allmain.c
@@ -876,7 +876,7 @@ enum earlyarg e_arg;
  *                    optimization so that display output
  *                    can be debugged without buffering.
  */
-void
+STATIC_OVL void
 debug_fields(opts)
 const char *opts;
 {
diff --git a/src/apply.c b/src/apply.c
index 879c6a3cb..5bc67850a 100644
--- a/src/apply.c
+++ b/src/apply.c
@@ -1611,7 +1611,7 @@ int x,y;
             && is_valid_jump_pos(x, y, jumping_is_magic, FALSE));
 }
 
-void
+STATIC_OVL void
 display_jump_positions(state)
 int state;
 {
@@ -2870,7 +2870,7 @@ static const char
     cant_reach[] = "can't reach that spot from here.";
 
 /* find pos of monster in range, if only one monster */
-boolean
+STATIC_OVL boolean
 find_poleable_mon(pos, min_range, max_range)
 coord *pos;
 int min_range, max_range;
@@ -2926,7 +2926,7 @@ int x, y;
             && distu(x, y) <= polearm_range_max);
 }
 
-void
+STATIC_OVL void
 display_polearm_positions(state)
 int state;
 {
diff --git a/src/botl.c b/src/botl.c
index 06f0a01b5..4a856a211 100644
--- a/src/botl.c
+++ b/src/botl.c
@@ -561,7 +561,7 @@ static long bl_hilite_moves = 0L;
 static unsigned long cond_hilites[BL_ATTCLR_MAX];
 static int now_or_before_idx = 0; /* 0..1 for array[2][] first index */
 
-void
+STATIC_OVL void
 bot_via_windowport()
 {
     char buf[BUFSZ];
@@ -2812,7 +2812,7 @@ status_hilite_linestr_gather()
 }
 
 
-char *
+STATIC_OVL char *
 status_hilite2str(hl)
 struct hilite_s *hl;
 {
diff --git a/src/cmd.c b/src/cmd.c
index d577d8e91..8fd6d5f68 100644
--- a/src/cmd.c
+++ b/src/cmd.c
@@ -2576,7 +2576,7 @@ int final;
 }
 
 /* attributes: intrinsics and the like, other non-obvious capabilities */
-void
+STATIC_OVL void
 attributes_enlightenment(unused_mode, final)
 int unused_mode UNUSED;
 int final;
diff --git a/src/display.c b/src/display.c
index 8f7207ad9..70a008a0a 100644
--- a/src/display.c
+++ b/src/display.c
@@ -897,7 +897,7 @@ xchar x, y;
     }
 }
 
-int
+STATIC_OVL int
 tether_glyph(x, y)
 int x, y;
 {
diff --git a/src/hack.c b/src/hack.c
index 74a13af98..95e5ea06c 100644
--- a/src/hack.c
+++ b/src/hack.c
@@ -1343,7 +1343,7 @@ domove()
         domove_attempting = 0L;
 }
 
-void
+STATIC_OVL void
 domove_core()
 {
     register struct monst *mtmp;
@@ -1940,7 +1940,7 @@ domove_core()
     }
 }
 
-void
+STATIC_OVL void
 maybe_smudge_engr(x1,y1,x2,y2)
 int x1, y1, x2, y2;
 {
diff --git a/src/isaac64.c b/src/isaac64.c
index 9ccb0db55..4d19335a3 100644
--- a/src/isaac64.c
+++ b/src/isaac64.c
@@ -19,7 +19,9 @@
 #define ISAAC64_MASK ((uint64_t)0xFFFFFFFFFFFFFFFFULL)
 
 #if (defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L)
+#if !defined(HAS_INLINE)
 #define HAS_INLINE
+#endif
 #else
 # if (defined(__GNUC__) && __GNUC__ >= 2 && !defined(inline))
 # define inline __inline__
diff --git a/src/makemon.c b/src/makemon.c
index 0f731c353..2350e77a0 100644
--- a/src/makemon.c
+++ b/src/makemon.c
@@ -1033,7 +1033,7 @@ newmextra()
     return mextra;
 }
 
-boolean
+STATIC_OVL boolean
 makemon_rnd_goodpos(mon, gpflags, cc)
 struct monst *mon;
 unsigned gpflags;
diff --git a/src/mkmaze.c b/src/mkmaze.c
index 2a11ba4ed..a9d0c1461 100644
--- a/src/mkmaze.c
+++ b/src/mkmaze.c
@@ -619,7 +619,7 @@ fixup_special()
     num_lregions = 0;
 }
 
-void
+STATIC_OVL void
 check_ransacked(s)
 char *s;
 {
@@ -630,7 +630,7 @@ char *s;
 #define ORC_LEADER 1
 static const char *orcfruit[] = { "paddle cactus", "dwarven root" };
 
-void
+STATIC_OVL void
 migrate_orc(mtmp, mflags)
 struct monst *mtmp;
 unsigned long mflags;
@@ -695,7 +695,7 @@ struct monst *mtmp;
             add_to_minv(mtmp, otmp);
     }
 }
-void
+STATIC_OVL void
 migr_booty_item(otyp, gang)
 int otyp;
 const char *gang;
@@ -716,7 +716,7 @@ const char *gang;
     }
 }
 
-void
+STATIC_OVL void
 stolen_booty(VOID_ARGS)
 {
     char *gang, gang_name[BUFSZ];
diff --git a/src/mon.c b/src/mon.c
index 2a8a7f350..862125289 100644
--- a/src/mon.c
+++ b/src/mon.c
@@ -45,7 +45,7 @@ const char *warnings[] = {
 #endif /* 0 */
 
 
-void
+STATIC_OVL void
 sanity_check_single_mon(mtmp, chk_geno, msg)
 struct monst *mtmp;
 boolean chk_geno;
@@ -2735,7 +2735,7 @@ struct monst *mtmp;
     return;
 }
 
-void
+STATIC_OVL void
 deal_with_overcrowding(mtmp)
 struct monst *mtmp;
 {
diff --git a/src/objnam.c b/src/objnam.c
index bb876dfd8..59b6397cd 100644
--- a/src/objnam.c
+++ b/src/objnam.c
@@ -417,7 +417,7 @@ struct obj *obj;
     return xname_flags(obj, CXN_NORMAL);
 }
 
-char *
+STATIC_OVL char *
 xname_flags(obj, cxn_flags)
 register struct obj *obj;
 unsigned cxn_flags; /* bitmask of CXN_xxx values */
@@ -2576,7 +2576,7 @@ const char *oldstr;
     return bp;
 }
 
-boolean
+STATIC_OVL boolean
 badman(basestr, to_plural)
 const char *basestr;
 boolean to_plural;            /* true => makeplural, false => makesingular */
diff --git a/src/options.c b/src/options.c
index 3155275ec..2f601df33 100644
--- a/src/options.c
+++ b/src/options.c
@@ -1602,7 +1602,7 @@ int typ;
     return (char *) 0;
 }
 
-int
+STATIC_OVL int
 query_msgtype()
 {
     winid tmpwin;
@@ -1796,7 +1796,7 @@ const char *errmsg;
     return retval;
 }
 
-boolean
+STATIC_OVL boolean
 add_menu_coloring_parsed(str, c, a)
 char *str;
 int c, a;
diff --git a/src/pager.c b/src/pager.c
index 02c61f966..96abfef26 100644
--- a/src/pager.c
+++ b/src/pager.c
@@ -1409,7 +1409,7 @@ static const char *suptext2[] = {
     (char *) 0,
 };
 
-void
+STATIC_OVL void
 do_supplemental_info(name, pm, without_asking)
 char *name;
 struct permonst *pm;
@@ -1885,61 +1885,61 @@ docontact(VOID_ARGS)
     destroy_nhwindow(cwin);
 }
 
-void
+STATIC_OVL void
 dispfile_help(VOID_ARGS)
 {
     display_file(HELP, TRUE);
 }
 
-void
+STATIC_OVL void
 dispfile_shelp(VOID_ARGS)
 {
     display_file(SHELP, TRUE);
 }
 
-void
+STATIC_OVL void
 dispfile_optionfile(VOID_ARGS)
 {
     display_file(OPTIONFILE, TRUE);
 }
 
-void
+STATIC_OVL void
 dispfile_license(VOID_ARGS)
 {
     display_file(LICENSE, TRUE);
 }
 
-void
+STATIC_OVL void
 dispfile_debughelp(VOID_ARGS)
 {
     display_file(DEBUGHELP, TRUE);
 }
 
-void
+STATIC_OVL void
 hmenu_doextversion(VOID_ARGS)
 {
     (void) doextversion();
 }
 
-void
+STATIC_OVL void
 hmenu_dohistory(VOID_ARGS)
 {
     (void) dohistory();
 }
 
-void
+STATIC_OVL void
 hmenu_dowhatis(VOID_ARGS)
 {
     (void) dowhatis();
 }
 
-void
+STATIC_OVL void
 hmenu_dowhatdoes(VOID_ARGS)
 {
     (void) dowhatdoes();
 }
 
-void
+STATIC_OVL void
 hmenu_doextlist(VOID_ARGS)
 {
     (void) doextlist();
diff --git a/src/pickup.c b/src/pickup.c
index fe25f8a0f..e47d989da 100644
--- a/src/pickup.c
+++ b/src/pickup.c
@@ -1710,7 +1710,7 @@ int x, y;
     return FALSE;
 }
 
-int
+STATIC_OVL int
 do_loot_cont(cobjp, cindex, ccount)
 struct obj **cobjp;
 int cindex, ccount; /* index of this container (1..N), number of them (N) */
diff --git a/src/questpgr.c b/src/questpgr.c
index 7d58fd89a..5c04c6cdf 100644
--- a/src/questpgr.c
+++ b/src/questpgr.c
@@ -578,7 +578,7 @@ int how;
         putmsghistory(out_line, FALSE);
 }
 
-boolean
+STATIC_OVL boolean
 skip_pager(common)
 boolean common;
 {
diff --git a/src/shk.c b/src/shk.c
index 26e7b66a5..fa29b1f31 100644
--- a/src/shk.c
+++ b/src/shk.c
@@ -2725,7 +2725,7 @@ boolean ininv, dummy, silent;
     }
 }
 
-void
+STATIC_OVL void
 append_honorific(buf)
 char *buf;
 {
diff --git a/util/makedefs.c b/util/makedefs.c
index 42108cc79..073cbf95d 100644
--- a/util/makedefs.c
+++ b/util/makedefs.c
@@ -951,7 +951,7 @@ unsigned long old_rumor_offset;
     return rumor_offset;
 }
 
-void
+STATIC_OVL void
 do_rnd_access_file(fname)
 const char *fname;
 {
@@ -1416,7 +1416,7 @@ do_date()
     return;
 }
 
-boolean
+STATIC_OVL boolean
 get_gitinfo(githash, gitbranch)
 char *githash, *gitbranch;
 {
diff --git a/win/tty/wintty.c b/win/tty/wintty.c
index 0422129fd..63861d62b 100644
--- a/win/tty/wintty.c
+++ b/win/tty/wintty.c
@@ -4132,7 +4132,7 @@ boolean force_update;
  * must be updated because they need to change.
  * This is now done at an individual field case-by-case level.
  */
-boolean
+STATIC_OVL boolean
 check_fields(forcefields, sz)
 boolean forcefields;
 int sz[3];
-- 
2.49.0