From 61dde63e3bdcdca9e352ec91442137e9ace5f75d Mon Sep 17 00:00:00 2001 From: Tim Peters Date: Sat, 27 Oct 2001 05:30:17 +0000 Subject: [PATCH] vgetargskeywords: Removed one of the mysterious PyErr_Clear() calls. The "need" for this was probably removed by an earlier patch that stopped the loop right before it from passing NULL to a dict lookup routine. I still haven't convinced myself that the next loop is correct, so am leaving the next mysterious PyErr_Clear() call in for now. --- Python/getargs.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/Python/getargs.c b/Python/getargs.c index 9796b5e839..a68940a57c 100644 --- a/Python/getargs.c +++ b/Python/getargs.c @@ -1099,18 +1099,9 @@ vgetargskeywords(PyObject *args, PyObject *keywords, char *format, } } } - /* XXX The loop just above didn't used to break when hitting the - end of kwlist, so could pass NULL on to PyMapping_HasKeyString, - which sets a "NULL argument to internal routine" error then. - However, the comment below doesn't give any clues about which - 'error string' it's talking about, so darned hard to say whether - the PyErr_Clear() still serves a purpose. - */ - PyErr_Clear(); /* I'm not which Py functions set the error string */ - + /* required arguments missing from args can be supplied by keyword arguments */ - len = nargs; if (keywords && nargs < min) { for (i = nargs; i < min; i++) { -- 2.40.0