From 618dfd65e4915fbd71247a960ef15e6c281d4fec Mon Sep 17 00:00:00 2001
From: Marcel Raad <MarcelRaad@users.noreply.github.com>
Date: Tue, 18 Aug 2015 09:39:38 +0200
Subject: [PATCH] inet_pton.c: Fix MSVC run-time check failure
Visual Studio complains with a message box:
"Run-Time Check Failure #1 - A cast to a smaller data type has caused a
loss of data. If this was intentional, you should mask the source of
the cast with the appropriate bitmask.
For example:
char c = (i & 0xFF);
Changing the code in this way will not affect the quality of the
resulting optimized code."
This is because only 'val' is cast to unsigned char, so the "& 0xff" has
no effect.
Closes #387
---
lib/inet_pton.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/inet_pton.c b/lib/inet_pton.c
index f50b365da..34dfc31e7 100644
--- a/lib/inet_pton.c
+++ b/lib/inet_pton.c
@@ -189,7 +189,7 @@ inet_pton6(const char *src, unsigned char *dst)
if(tp + INT16SZ > endp)
return (0);
*tp++ = (unsigned char) (val >> 8) & 0xff;
- *tp++ = (unsigned char) val & 0xff;
+ *tp++ = (unsigned char) (val & 0xff);
saw_xdigit = 0;
val = 0;
continue;
--
2.40.0