From 605b3b81db9b4e7921be5a213c85cd84ddcaf374 Mon Sep 17 00:00:00 2001 From: Sanjay Patel Date: Tue, 1 Nov 2016 20:43:00 +0000 Subject: [PATCH] [ValueTracking] remove TODO comment; NFC InstCombine should always canonicalize patterns like the one shown in the comment when visiting 'select' insts in adjustMinMax(). Scalars were already handled there, and vector splats are handled after: https://reviews.llvm.org/rL285732 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@285744 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/ValueTracking.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/Analysis/ValueTracking.cpp b/lib/Analysis/ValueTracking.cpp index f1b91d2fbb5..c8cba38d566 100644 --- a/lib/Analysis/ValueTracking.cpp +++ b/lib/Analysis/ValueTracking.cpp @@ -3991,8 +3991,6 @@ static SelectPatternResult matchSelectPattern(CmpInst::Predicate Pred, } } - // TODO: (X > 4) ? X : 5 --> (X >= 5) ? X : 5 --> MAX(X, 5) - return {SPF_UNKNOWN, SPNB_NA, false}; } -- 2.40.0