From 6048ca59b7910e415dadd49c9232cef8d4f644e7 Mon Sep 17 00:00:00 2001 From: Yury Gribov Date: Thu, 28 Jan 2016 09:27:46 +0000 Subject: [PATCH] Small refactor in isBeforeInTranslationUnit. Differential Revision: http://reviews.llvm.org/D15804 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@259030 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Basic/SourceManager.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/Basic/SourceManager.cpp b/lib/Basic/SourceManager.cpp index 4c501616a3..959d4d414a 100644 --- a/lib/Basic/SourceManager.cpp +++ b/lib/Basic/SourceManager.cpp @@ -2089,10 +2089,10 @@ bool SourceManager::isBeforeInTranslationUnit(SourceLocation LHS, // Clear the lookup cache, it depends on a common location. IsBeforeInTUCache.clear(); - llvm::MemoryBuffer *LBuf = getBuffer(LOffs.first); - llvm::MemoryBuffer *RBuf = getBuffer(ROffs.first); - bool LIsBuiltins = strcmp("", LBuf->getBufferIdentifier()) == 0; - bool RIsBuiltins = strcmp("", RBuf->getBufferIdentifier()) == 0; + const char *LB = getBuffer(LOffs.first)->getBufferIdentifier(); + const char *RB = getBuffer(ROffs.first)->getBufferIdentifier(); + bool LIsBuiltins = strcmp("", LB) == 0; + bool RIsBuiltins = strcmp("", RB) == 0; // Sort built-in before non-built-in. if (LIsBuiltins || RIsBuiltins) { if (LIsBuiltins != RIsBuiltins) @@ -2101,8 +2101,8 @@ bool SourceManager::isBeforeInTranslationUnit(SourceLocation LHS, // lower IDs come first. return LOffs.first < ROffs.first; } - bool LIsAsm = strcmp("", LBuf->getBufferIdentifier()) == 0; - bool RIsAsm = strcmp("", RBuf->getBufferIdentifier()) == 0; + bool LIsAsm = strcmp("", LB) == 0; + bool RIsAsm = strcmp("", RB) == 0; // Sort assembler after built-ins, but before the rest. if (LIsAsm || RIsAsm) { if (LIsAsm != RIsAsm) -- 2.40.0