From 6022f00f3509eee1834c2aa5a94fa22d09380bba Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Tue, 18 Dec 2018 01:36:06 +0000 Subject: [PATCH] [codeview] Update comment on aligning symbol records git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@349433 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/AsmPrinter/CodeViewDebug.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp b/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp index 78e5f5d215b..4132b1a30c4 100644 --- a/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp +++ b/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp @@ -2831,8 +2831,10 @@ MCSymbol *CodeViewDebug::beginSymbolRecord(SymbolKind SymKind) { } void CodeViewDebug::endSymbolRecord(MCSymbol *SymEnd) { - // Symbol records in object files are not aligned, although we are considering - // it for linker performance reasons. + // MSVC does not pad out symbol records to four bytes, but LLVM does to avoid + // an extra copy of every symbol record in LLD. This increases object file + // size by less than 1% in the clang build, and is compatible with the Visual + // C++ linker. OS.EmitValueToAlignment(4); OS.EmitLabel(SymEnd); } -- 2.50.1