From 5e9e641b3d2a93c213747e05bc9a4c1f7bd822f0 Mon Sep 17 00:00:00 2001 From: "Todd C. Miller" Date: Mon, 29 Jan 2018 14:02:21 -0700 Subject: [PATCH] Check the return value of sudoers_debug_register(). Coverity CID 182574 --- plugins/sudoers/testsudoers.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/plugins/sudoers/testsudoers.c b/plugins/sudoers/testsudoers.c index 31b02a252..4982a501d 100644 --- a/plugins/sudoers/testsudoers.c +++ b/plugins/sudoers/testsudoers.c @@ -115,7 +115,7 @@ main(int argc, char *argv[]) char *p, *grfile, *pwfile; const char *errstr; int match, host_match, runas_match, cmnd_match; - int ch, dflag, exitcode = 0; + int ch, dflag, exitcode = EXIT_FAILURE; debug_decl(main, SUDOERS_DEBUG_MAIN) #if defined(SUDO_DEVEL) && defined(__OpenBSD__) @@ -135,8 +135,9 @@ main(int argc, char *argv[]) /* Initialize the debug subsystem. */ if (sudo_conf_read(NULL, SUDO_CONF_DEBUG) == -1) - exit(EXIT_FAILURE); - sudoers_debug_register(getprogname(), sudo_conf_debug_files(getprogname())); + goto done; + if (!sudoers_debug_register(getprogname(), sudo_conf_debug_files(getprogname()))) + goto done; dflag = 0; grfile = pwfile = NULL; -- 2.40.0