From 5e00fe65225e5e738bf69e237d3e73ca301f25f4 Mon Sep 17 00:00:00 2001 From: David Bolvansky Date: Tue, 24 Sep 2019 20:10:57 +0000 Subject: [PATCH] [NFC] Strenghten preconditions for warning git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@372775 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaChecking.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/Sema/SemaChecking.cpp b/lib/Sema/SemaChecking.cpp index 02c0d489ae..28f4e06cd7 100644 --- a/lib/Sema/SemaChecking.cpp +++ b/lib/Sema/SemaChecking.cpp @@ -11321,7 +11321,8 @@ static void DiagnoseIntInBoolContext(Sema &S, Expr *E) { const auto *RHS = getIntegerLiteral(BO->getRHS()); if (LHS && LHS->getValue() == 0) S.Diag(ExprLoc, diag::warn_left_shift_always) << 0; - else if (RHS && RHS->getValue().isNonNegative() && + else if (!E->isValueDependent() && LHS && RHS && + RHS->getValue().isNonNegative() && E->EvaluateAsInt(Result, S.Context, Expr::SE_AllowSideEffects)) S.Diag(ExprLoc, diag::warn_left_shift_always) << (Result.Val.getInt() != 0); -- 2.50.1