From 5d2b44eaf680cf69b9376dc69f924719047cddcb Mon Sep 17 00:00:00 2001 From: Qualys Security Advisory Date: Thu, 1 Jan 1970 00:00:00 +0000 Subject: [PATCH] pgrep: Replace buf+1 with buf in read_pidfile(). Unless we missed something, this makes it unnecessarily difficult to read/audit. --- pgrep.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pgrep.c b/pgrep.c index 67632661..dead923c 100644 --- a/pgrep.c +++ b/pgrep.c @@ -251,11 +251,11 @@ static struct el *read_pidfile(void) if(opt_lock && !has_flock(fd) && !has_fcntl(fd)) goto out; memset(buf,'\0',sizeof buf); - n = read(fd,buf+1,sizeof buf-2); + n = read(fd,buf,sizeof buf-1); if (n<1) goto out; - pid = strtoul(buf+1,&endp,10); - if(endp<=buf+1 || pid<1 || pid>0x7fffffff) + pid = strtoul(buf,&endp,10); + if(endp<=buf || pid<1 || pid>0x7fffffff) goto out; if(*endp && !isspace(*endp)) goto out; -- 2.40.0