From 5cb0ef4aed9a4a1741260e16a99d18682335ab9b Mon Sep 17 00:00:00 2001 From: Douglas Gregor Date: Fri, 6 May 2011 23:32:38 +0000 Subject: [PATCH] Implement a minor optimization by not introducing declarations into DeclContext's lookup table when they aren't in any identifier namespace. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@131037 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/AST/DeclBase.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/AST/DeclBase.cpp b/lib/AST/DeclBase.cpp index 8f3388ee58..1766d39c14 100644 --- a/lib/AST/DeclBase.cpp +++ b/lib/AST/DeclBase.cpp @@ -1166,10 +1166,10 @@ void DeclContext::makeDeclVisibleInContextImpl(NamedDecl *D) { if (!D->getDeclName()) return; - // FIXME: This feels like a hack. Should DeclarationName support - // template-ids, or is there a better way to keep specializations - // from being visible? - if (isa(D) || D->isTemplateParameter()) + // Skip entities that can't be found by name lookup into a particular + // context. + if ((D->getIdentifierNamespace() == 0 && !isa(D)) || + D->isTemplateParameter()) return; ASTContext *C = 0; -- 2.40.0