From 5c2a7c6e97741564ab4ff336eac8d8227485dd4c Mon Sep 17 00:00:00 2001 From: Robert Haas Date: Wed, 26 Jan 2011 06:42:51 -0500 Subject: [PATCH] Add a comment explaining why we force physical removal of OIDs. Noah Misch, slightly revised. --- src/backend/commands/tablecmds.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index 8a281968ad..8fa9d7fa7f 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -4942,7 +4942,9 @@ ATExecDropColumn(List **wqueue, Relation rel, const char *colName, /* * If we dropped the OID column, must adjust pg_class.relhasoids and tell - * Phase 3 to physically get rid of the column. + * Phase 3 to physically get rid of the column. We formerly left the + * column in place physically, but this caused subtle problems. See + * http://archives.postgresql.org/pgsql-hackers/2009-02/msg00363.php */ if (attnum == ObjectIdAttributeNumber) { -- 2.40.0