From 5b3b1006bbb25902a6981b3447032d2b743be4c4 Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Mon, 22 Jul 2013 23:50:57 +0200 Subject: [PATCH] Issue #18520: Fix _PyDict_GetItemId(), suppress _PyUnicode_FromId() error As PyDict_GetItem(), _PyDict_GetItemId() suppresses all errors that may occur, for historical reasons. --- Objects/dictobject.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Objects/dictobject.c b/Objects/dictobject.c index 36c710ed5b..e0cb8ac753 100644 --- a/Objects/dictobject.c +++ b/Objects/dictobject.c @@ -2684,8 +2684,10 @@ _PyDict_GetItemId(PyObject *dp, struct _Py_Identifier *key) { PyObject *kv; kv = _PyUnicode_FromId(key); /* borrowed */ - if (kv == NULL) + if (kv == NULL) { + PyErr_Clear(); return NULL; + } return PyDict_GetItem(dp, kv); } -- 2.50.1