From 5b231147fe11f1cb702386b61a84c094ab416239 Mon Sep 17 00:00:00 2001 From: Michael Friedrich Date: Mon, 27 Nov 2017 12:09:42 +0100 Subject: [PATCH] Silence UpdateRepository message errors Mixed setups with 2.8 and 2.7 will log this error every time a new message is received. While this is truly an error, it just fills the log to infinity. Should be used for debug only. fixes #5776 refs #5804 --- lib/remote/jsonrpcconnection.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/remote/jsonrpcconnection.cpp b/lib/remote/jsonrpcconnection.cpp index 3d9cacaf0..e6cd9a3c8 100644 --- a/lib/remote/jsonrpcconnection.cpp +++ b/lib/remote/jsonrpcconnection.cpp @@ -208,11 +208,12 @@ void JsonRpcConnection::MessageHandler(const String& jsonString) try { ApiFunction::Ptr afunc = ApiFunction::GetByName(method); - if (!afunc) - Log(LogWarning, "JsonRpcConnection") + if (!afunc) { + Log(LogNotice, "JsonRpcConnection") << "Call to non-existent function '" << method << "' from endpoint '" << m_Identity << "'."; - else + } else { resultMessage->Set("result", afunc->Invoke(origin, message->Get("params"))); + } } catch (const std::exception& ex) { /* TODO: Add a user readable error message for the remote caller */ String diagInfo = DiagnosticInformation(ex); -- 2.40.0