From 5a76d409162c036ac367ee84cc7d5816cf7a3aed Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Wed, 3 Oct 2018 02:01:19 +0000 Subject: [PATCH] OpenCL: Mark printf format string argument Fixes not warning on format string errors. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@343653 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Headers/opencl-c.h | 2 +- test/SemaOpenCL/printf-format-string-warnings.cl | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 test/SemaOpenCL/printf-format-string-warnings.cl diff --git a/lib/Headers/opencl-c.h b/lib/Headers/opencl-c.h index e481c792df..d1d9c1014e 100644 --- a/lib/Headers/opencl-c.h +++ b/lib/Headers/opencl-c.h @@ -14462,7 +14462,7 @@ half16 __ovld __cnfn shuffle2(half16 x, half16 y, ushort16 mask); #if __OPENCL_C_VERSION__ >= CL_VERSION_1_2 // OpenCL v1.2 s6.12.13, v2.0 s6.13.13 - printf -int printf(__constant const char* st, ...); +int printf(__constant const char* st, ...) __attribute__((format(printf, 1, 2))); #endif // OpenCL v1.1 s6.11.3, v1.2 s6.12.14, v2.0 s6.13.14 - Image Read and Write Functions diff --git a/test/SemaOpenCL/printf-format-string-warnings.cl b/test/SemaOpenCL/printf-format-string-warnings.cl new file mode 100644 index 0000000000..2b9c5cc3f3 --- /dev/null +++ b/test/SemaOpenCL/printf-format-string-warnings.cl @@ -0,0 +1,13 @@ +// RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only -cl-std=CL2.0 -finclude-default-header + +// Make sure warnings are produced based on printf format strings. + + +kernel void format_string_warnings(__constant char* arg) { + + printf("%d", arg); // expected-warning {{format specifies type 'int' but the argument has type '__constant char *'}} + + printf("not enough arguments %d %d", 4); // expected-warning {{more '%' conversions than data arguments}} + + printf("too many arguments", 4); // expected-warning {{data argument not used by format string}} +} -- 2.50.1