From 59f800d05866ef447e1337bc8f2c9a54063f6eba Mon Sep 17 00:00:00 2001 From: Simon Riggs Date: Sat, 2 Feb 2013 18:55:03 +0000 Subject: [PATCH] Mark vacuum_defer_cleanup_age as PGC_POSTMASTER. Following bug analysis of #7819 by Tom Lane --- doc/src/sgml/config.sgml | 3 +-- src/backend/utils/misc/guc.c | 7 ++++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index c1a90d1fba..59a48cf3f0 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -1998,8 +1998,7 @@ SET ENABLE_SEQSCAN TO OFF; is measured in terms of number of write transactions occurring on the primary server, it is difficult to predict just how much additional grace time will be made available to standby queries. - This parameter can only be set in the postgresql.conf - file or on the server command line. + This parameter can only be set at server start. diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 2483587fa3..92ea02a507 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -1631,7 +1631,12 @@ static struct config_int ConfigureNamesInt[] = }, { - {"vacuum_defer_cleanup_age", PGC_SIGHUP, WAL_REPLICATION, + /* + * Setting this to a higher value without restarting postmaster + * can cause various bugs in TOAST object removal, CLUSTER and + * possibly other places, so this must be changed only on restart. + */ + {"vacuum_defer_cleanup_age", PGC_POSTMASTER, WAL_REPLICATION, gettext_noop("Number of transactions by which VACUUM and HOT cleanup should be deferred, if any."), NULL }, -- 2.40.0