From 59b6d5ae1c42515340a48040f6ff576a6f48a9c3 Mon Sep 17 00:00:00 2001 From: Nuno Lopes Date: Fri, 18 Apr 2008 22:43:39 +0000 Subject: [PATCH] fix __attribute__(format) for struct function pointer fields git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@49938 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/SemaDecl.cpp | 10 +++++++--- test/Sema/format-attribute.c | 5 +++++ 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/lib/Sema/SemaDecl.cpp b/lib/Sema/SemaDecl.cpp index 015ba8c65d..e51b7974ae 100644 --- a/lib/Sema/SemaDecl.cpp +++ b/lib/Sema/SemaDecl.cpp @@ -2268,10 +2268,14 @@ void Sema::HandleNothrowAttribute(Decl *d, AttributeList *rawAttr) { } static const FunctionTypeProto *getFunctionProto(Decl *d) { - ValueDecl *decl = dyn_cast(d); - if (!decl) return 0; + QualType Ty; - QualType Ty = decl->getType(); + if (ValueDecl *decl = dyn_cast(d)) + Ty = decl->getType(); + else if (FieldDecl *decl = dyn_cast(d)) + Ty = decl->getType(); + else + return 0; if (Ty->isFunctionPointerType()) { const PointerType *PtrTy = Ty->getAsPointerType(); diff --git a/test/Sema/format-attribute.c b/test/Sema/format-attribute.c index df3e4b5959..8eefe3f065 100644 --- a/test/Sema/format-attribute.c +++ b/test/Sema/format-attribute.c @@ -17,3 +17,8 @@ void z(char *str, int c, ...) __attribute__((format(strftime, 1,2))); // expecte int (*f_ptr)(char*,...) __attribute__((format(printf, 1,2))); // no-error int (*f2_ptr)(double,...) __attribute__((format(printf, 1, 2))); // expected-error {{format argument not a string type}} + +struct _mystruct { + int (*printf)(const char *format, ...) __attribute__((__format__(printf, 1, 2))); // no-error + int (*printf2)(double format, ...) __attribute__((__format__(printf, 1, 2))); // expected-error {{format argument not a string type}} +}; -- 2.40.0