From 597fe911c137f5d3ccd6678925a0848d2cc1455e Mon Sep 17 00:00:00 2001 From: Alex Lorenz Date: Mon, 30 Oct 2017 22:55:11 +0000 Subject: [PATCH] Typo correct the condition of 'do-while' before exiting its scope rdar://35172419 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@316966 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Parse/ParseStmt.cpp | 3 +++ test/SemaObjCXX/typo-correction.mm | 34 +++++++++++++++++++++++++++++- 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/lib/Parse/ParseStmt.cpp b/lib/Parse/ParseStmt.cpp index 65c3f21f2d..e8cf7d5fa4 100644 --- a/lib/Parse/ParseStmt.cpp +++ b/lib/Parse/ParseStmt.cpp @@ -1479,6 +1479,9 @@ StmtResult Parser::ParseDoStatement() { DiagnoseAndSkipCXX11Attributes(); ExprResult Cond = ParseExpression(); + // Correct the typos in condition before closing the scope. + if (Cond.isUsable()) + Cond = Actions.CorrectDelayedTyposInExpr(Cond); T.consumeClose(); DoScope.Exit(); diff --git a/test/SemaObjCXX/typo-correction.mm b/test/SemaObjCXX/typo-correction.mm index 8dcda7921f..3f8a082a84 100644 --- a/test/SemaObjCXX/typo-correction.mm +++ b/test/SemaObjCXX/typo-correction.mm @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 %s -verify -fsyntax-only +// RUN: %clang_cc1 %s -verify -fsyntax-only -Wno-objc-root-class class ClassA {}; @@ -55,3 +55,35 @@ void invalidNameInIvarAndPropertyBase() { typoCandidate.x = 0; // expected-error {{use of undeclared identifier 'typoCandidate'; did you mean '_typoCandidate'?}} } @end + +// rdar://35172419 +// The scope of 'do-while' ends before typo-correction takes place. + +struct Mat2 { int rows; }; + +@implementation ImplNoInt // expected-warning {{cannot find interface declaration for 'ImplNoInt'}} + +- (void)typoCorrentInDoWhile { + Mat2 tlMat1; // expected-note {{'tlMat1' declared here}} + // Create many scopes to exhaust the cache. + do { + for (int index = 0; index < 2; index++) { + if (true) { + for (int specialTileType = 1; specialTileType < 5; specialTileType++) { + for (int i = 0; i < 10; i++) { + for (double scale = 0.95; scale <= 1.055; scale += 0.05) { + for (int j = 0; j < 10; j++) { + if (1 > 0.9) { + for (int sptile = 1; sptile < 5; sptile++) { + } + } + } + } + } + } + } + } + } while (tlMat.rows); // expected-error {{use of undeclared identifier 'tlMat'; did you mean 'tlMat1'}} +} + +@end -- 2.40.0