From 584f6645a33fb79efab714446d745a16f61b6307 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Mon, 24 Oct 2016 18:11:05 +0000 Subject: [PATCH] Clarify that MSVC is not the issue here anymore. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@284997 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/IR/PassManager.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/llvm/IR/PassManager.h b/include/llvm/IR/PassManager.h index 4715777601d..57d0c93514e 100644 --- a/include/llvm/IR/PassManager.h +++ b/include/llvm/IR/PassManager.h @@ -241,8 +241,10 @@ public: /// /// It can be passed a flag to get debug logging as the passes are run. PassManager(bool DebugLogging = false) : DebugLogging(DebugLogging) {} - // We have to explicitly define all the special member functions because MSVC - // refuses to generate them. + // FIXME: These are equivalent to the default move constructor/move + // assignment. However, using = default triggers linker errors due to the + // explicit instantiations below. Find away to use the default and remove the + // duplicated code here. PassManager(PassManager &&Arg) : Passes(std::move(Arg.Passes)), DebugLogging(std::move(Arg.DebugLogging)) {} -- 2.40.0