From 57a3feb4225566ed9dda92d0e1e5c08c11a3448f Mon Sep 17 00:00:00 2001 From: Xinchen Hui Date: Mon, 24 Feb 2014 18:15:40 +0800 Subject: [PATCH] Fixed memory leak in strrev --- ext/standard/string.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/ext/standard/string.c b/ext/standard/string.c index 1e8e55be93..be4d874b06 100644 --- a/ext/standard/string.c +++ b/ext/standard/string.c @@ -3121,15 +3121,16 @@ PHP_FUNCTION(strtr) PHP_FUNCTION(strrev) { char *str; - char *e, *n, *p; + char *e, *p; int str_len; + zend_string *n; if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &str, &str_len) == FAILURE) { return; } - n = emalloc(str_len+1); - p = n; + n = STR_ALLOC(str_len, 0); + p = n->val; e = str + str_len; @@ -3139,8 +3140,7 @@ PHP_FUNCTION(strrev) *p = '\0'; -//??? RETVAL_STRINGL(n, str_len, 0); - RETVAL_STRINGL(n, str_len); + RETVAL_STR(n); } /* }}} */ -- 2.50.1