From 5750b81beb0d508278011c410b01acabc9c7ca05 Mon Sep 17 00:00:00 2001 From: Fariborz Jahanian Date: Fri, 9 Jul 2010 21:27:28 +0000 Subject: [PATCH] Instantiation of byref variable in block literal expression. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@108019 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Sema/TreeTransform.h | 4 ++++ test/CodeGenCXX/instantiate-blocks.cpp | 6 +++++- test/SemaCXX/instantiate-blocks.cpp | 19 +++++++++++++++++++ 3 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 test/SemaCXX/instantiate-blocks.cpp diff --git a/lib/Sema/TreeTransform.h b/lib/Sema/TreeTransform.h index db5e2d10f4..05ae38e84a 100644 --- a/lib/Sema/TreeTransform.h +++ b/lib/Sema/TreeTransform.h @@ -6279,6 +6279,10 @@ TreeTransform::TransformBlockDeclRefExpr(BlockDeclRefExpr *E) { if (!ND) return SemaRef.ExprError(); + // Is this instantiation of a __block variable? + if (E->getDecl()->getAttr()) + ND->addAttr(::new (SemaRef.Context) BlocksAttr(BlocksAttr::ByRef)); + if (!getDerived().AlwaysRebuild() && ND == E->getDecl()) { // Mark it referenced in the new context regardless. diff --git a/test/CodeGenCXX/instantiate-blocks.cpp b/test/CodeGenCXX/instantiate-blocks.cpp index 8c1c8dd234..7246f69e8e 100644 --- a/test/CodeGenCXX/instantiate-blocks.cpp +++ b/test/CodeGenCXX/instantiate-blocks.cpp @@ -18,7 +18,11 @@ int test1(void) template void foo(T t, T1 r) { T block_arg; - T1 (^block)(char, T, T1, double) = ^ T1 (char ch, T arg, T1 arg2, double d1) { return block_arg+arg; }; + __block T1 byref_block_arg; + + T1 (^block)(char, T, T1, double) = + ^ T1 (char ch, T arg, T1 arg2, double d1) { byref_block_arg = arg2; + return byref_block_arg + arg; }; void (^block2)() = ^{}; } diff --git a/test/SemaCXX/instantiate-blocks.cpp b/test/SemaCXX/instantiate-blocks.cpp new file mode 100644 index 0000000000..a4001a75fa --- /dev/null +++ b/test/SemaCXX/instantiate-blocks.cpp @@ -0,0 +1,19 @@ +// RUN: %clang_cc1 -fblocks -fsyntax-only -verify %s +// rdar: // 6182276 + +template void foo(T t, T1 r) +{ + T block_arg; + __block T1 byref_block_arg; + + T1 (^block)(T) = ^ T1 (T arg) { + byref_block_arg = arg; + block_arg = arg; // expected-error {{variable is not assignable (missing __block type specifier)}} + return block_arg+arg; }; +} + +int main(void) +{ + foo(100, 'a'); // expected-note {{in instantiation of function template specialization 'foo' requested here}} +} + -- 2.40.0